Re: [PATCH v1 1/1] QIOChannelSocket: Fix zero-copy send so socket flush works

On Wed, Jun 8, 2022 at 5:55 PM Peter Xu wrote: > > On Wed, Jun 08, 2022 at 04:26:10PM -0400, Peter Xu wrote: > > On Wed, Jun 08, 2022 at 03:18:09PM -0300, Leonardo Bras wrote: > > > Somewhere between v6 and v7 the of the zero-copy-send patchset a crucial > > > part of the flushing mechanism got mi

Re: [PATCH v1 1/1] QIOChannelSocket: Fix zero-copy send so socket flush works

On Wed, Jun 08, 2022 at 04:26:10PM -0400, Peter Xu wrote: > On Wed, Jun 08, 2022 at 03:18:09PM -0300, Leonardo Bras wrote: > > Somewhere between v6 and v7 the of the zero-copy-send patchset a crucial > > part of the flushing mechanism got missing: incrementing zero_copy_queued. > > > > Without tha

Re: [PATCH v1 1/1] QIOChannelSocket: Fix zero-copy send so socket flush works

Hello Daniel, On Wed, Jun 8, 2022 at 3:46 PM Daniel P. Berrangé wrote: > > On Wed, Jun 08, 2022 at 03:18:09PM -0300, Leonardo Bras wrote: > > Somewhere between v6 and v7 the of the zero-copy-send patchset a crucial > > part of the flushing mechanism got missing: incrementing zero_copy_queued. > >

Re: [PATCH v1 1/1] QIOChannelSocket: Fix zero-copy send so socket flush works

On Wed, Jun 08, 2022 at 03:18:09PM -0300, Leonardo Bras wrote: > Somewhere between v6 and v7 the of the zero-copy-send patchset a crucial > part of the flushing mechanism got missing: incrementing zero_copy_queued. > > Without that, the flushing interface becomes a no-op, and there is no > garante

Re: [PATCH v1 1/1] QIOChannelSocket: Fix zero-copy send so socket flush works

On Wed, Jun 08, 2022 at 07:46:43PM +0100, Daniel P. Berrangé wrote: > On Wed, Jun 08, 2022 at 03:18:09PM -0300, Leonardo Bras wrote: > > Somewhere between v6 and v7 the of the zero-copy-send patchset a crucial > > part of the flushing mechanism got missing: incrementing zero_copy_queued. > > > > W

Re: [PATCH v1 1/1] QIOChannelSocket: Fix zero-copy send so socket flush works

On Wed, Jun 08, 2022 at 03:18:09PM -0300, Leonardo Bras wrote: > Somewhere between v6 and v7 the of the zero-copy-send patchset a crucial > part of the flushing mechanism got missing: incrementing zero_copy_queued. > > Without that, the flushing interface becomes a no-op, and there is no > garante

[PATCH v1 1/1] QIOChannelSocket: Fix zero-copy send so socket flush works

Somewhere between v6 and v7 the of the zero-copy-send patchset a crucial part of the flushing mechanism got missing: incrementing zero_copy_queued. Without that, the flushing interface becomes a no-op, and there is no garantee the buffer is really sent. This can go as bad as causing a corruption