Re: [PATCH v1 1/2] hw/cxl/device: read from register values in mdev_reg_read()

2023-12-03 Thread Davidlohr Bueso
On Thu, 30 Nov 2023, Jonathan Cameron wrote: If you mean generally harden the code we haven't fixed up for big endian systems then fair enough - that indeed needs doing. Yes, that was a braino, sorry for the confusion. Tricky to be sure we got it all right though unless we have a big endian

Re: [PATCH v1 1/2] hw/cxl/device: read from register values in mdev_reg_read()

2023-11-30 Thread Jonathan Cameron via
On Mon, 27 Nov 2023 12:27:02 -0800 Davidlohr Bueso wrote: > On Mon, 27 Nov 2023, Hyeonggon Yoo wrote: > > >In the current mdev_reg_read() implementation, it consistently returns > >that the Media Status is Ready (01b). This was fine until commit > >25a52959f99d ("hw/cxl: Add support for device s

Re: [PATCH v1 1/2] hw/cxl/device: read from register values in mdev_reg_read()

2023-11-27 Thread Davidlohr Bueso
On Tue, 28 Nov 2023, Hyeonggon Yoo wrote: All of them make sense to me. I will adjust, thanks! But I'm not confident enough to write a single description for all the changes so will split it into a few patches. May I add your Suggested-by (or Signed-off-by) in v2 as it will contain some part of

Re: [PATCH v1 1/2] hw/cxl/device: read from register values in mdev_reg_read()

2023-11-27 Thread Hyeonggon Yoo
On Tue, Nov 28, 2023 at 5:27 AM Davidlohr Bueso wrote: > > On Mon, 27 Nov 2023, Hyeonggon Yoo wrote: > > >In the current mdev_reg_read() implementation, it consistently returns > >that the Media Status is Ready (01b). This was fine until commit > >25a52959f99d ("hw/cxl: Add support for device sani

Re: [PATCH v1 1/2] hw/cxl/device: read from register values in mdev_reg_read()

2023-11-27 Thread Davidlohr Bueso
On Mon, 27 Nov 2023, Hyeonggon Yoo wrote: In the current mdev_reg_read() implementation, it consistently returns that the Media Status is Ready (01b). This was fine until commit 25a52959f99d ("hw/cxl: Add support for device sanitation") because the media was presumed to be ready. However, as pe

[PATCH v1 1/2] hw/cxl/device: read from register values in mdev_reg_read()

2023-11-27 Thread Hyeonggon Yoo
In the current mdev_reg_read() implementation, it consistently returns that the Media Status is Ready (01b). This was fine until commit 25a52959f99d ("hw/cxl: Add support for device sanitation") because the media was presumed to be ready. However, as per the CXL 3.0 spec "8.2.9.8.5.1 Sanitize (Opc