Both main loop thread and vCPU thread are allowed to call
pause_all_vcpus(), and in general resume_all_vcpus() is called
after it. Two issues live in pause_all_vcpus():
1. There is possibility that during thread T1 waits on
qemu_pause_cond with bql unlocked, other thread has called
pause_all_vcpus
On 17.03.24 09:37, Keqian Zhu via wrote:
Both main loop thread and vCPU thread are allowed to call
pause_all_vcpus(), and in general resume_all_vcpus() is called
after it. Two issues live in pause_all_vcpus():
In general, calling pause_all_vcpus() from VCPU threads is quite dangerous.
Do we ha
Hi David,
Thanks for reviewing.
On 17.03.24 09:37, Keqian Zhu via wrote:
>> Both main loop thread and vCPU thread are allowed to call
>> pause_all_vcpus(), and in general resume_all_vcpus() is called after
>> it. Two issues live in pause_all_vcpus():
>
>In general, calling pause_all_vcpus() fro
On 19.03.24 06:06, zhukeqian wrote:
Hi David,
Thanks for reviewing.
On 17.03.24 09:37, Keqian Zhu via wrote:
Both main loop thread and vCPU thread are allowed to call
pause_all_vcpus(), and in general resume_all_vcpus() is called after
it. Two issues live in pause_all_vcpus():
In general, ca
On 19.03.24 10:24, David Hildenbrand wrote:
On 19.03.24 06:06, zhukeqian wrote:
Hi David,
Thanks for reviewing.
On 17.03.24 09:37, Keqian Zhu via wrote:
Both main loop thread and vCPU thread are allowed to call
pause_all_vcpus(), and in general resume_all_vcpus() is called after
it. Two issue
On Tue, 19 Mar 2024 at 09:24, David Hildenbrand wrote:
> I spotted new pause_all_vcpus() / resume_all_vcpus() calls in
> hw/intc/arm_gicv3_kvm.c and
> thought they would be the problematic bit.
>
> Yeah, that's going to be problematic. Further note that a lot of code does
> not expect
> that the
On 19.03.24 15:23, Peter Maydell wrote:
On Tue, 19 Mar 2024 at 09:24, David Hildenbrand wrote:
I spotted new pause_all_vcpus() / resume_all_vcpus() calls in
hw/intc/arm_gicv3_kvm.c and
thought they would be the problematic bit.
Yeah, that's going to be problematic. Further note that a lot of
On Tue, 19 Mar 2024 at 14:46, David Hildenbrand wrote:
>
> On 19.03.24 15:23, Peter Maydell wrote:
> > On Tue, 19 Mar 2024 at 09:24, David Hildenbrand wrote:
> >> I spotted new pause_all_vcpus() / resume_all_vcpus() calls in
> >> hw/intc/arm_gicv3_kvm.c and
> >> thought they would be the problem
