Re: [PATCH v1 17/21] target/s390x: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-06 Thread Alex Bennée
Paolo Bonzini writes: > On 06/08/20 10:59, Cornelia Huck wrote: >>> bool stopped = false; >>> - >>> +bool bql = !qemu_mutex_iothread_locked(); >>> +if (bql) { >>> +qemu_mutex_lock_iothread(); >>> +} >> I'm not sure I like that conditional locking. Can we instead create

Re: [PATCH v1 17/21] target/s390x: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-06 Thread Paolo Bonzini
On 06/08/20 10:59, Cornelia Huck wrote: >> bool stopped = false; >> - >> +bool bql = !qemu_mutex_iothread_locked(); >> +if (bql) { >> +qemu_mutex_lock_iothread(); >> +} > I'm not sure I like that conditional locking. Can we instead create > __s390_cpu_do_interrupt() or so,

Re: [PATCH v1 17/21] target/s390x: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-06 Thread Cornelia Huck
On Wed, 5 Aug 2020 14:12:59 -0400 Robert Foley wrote: > This is part of a series of changes to remove the implied BQL > from the common code of cpu_handle_interrupt and > cpu_handle_exception. As part of removing the implied BQL > from the common code, we are pushing the BQL holding > down into

[PATCH v1 17/21] target/s390x: add BQL to do_interrupt and cpu_exec_interrupt

2020-08-05 Thread Robert Foley
This is part of a series of changes to remove the implied BQL from the common code of cpu_handle_interrupt and cpu_handle_exception. As part of removing the implied BQL from the common code, we are pushing the BQL holding down into the per-arch implementation functions of do_interrupt and cpu_exec