Re: [PATCH v1 2/2] vhost: Remove vhost_backend_can_merge() callback

2023-03-07 Thread David Hildenbrand
On 07.03.23 12:16, Igor Mammedov wrote: On Tue, 7 Mar 2023 11:25:48 +0100 Igor Mammedov wrote: On Thu, 16 Feb 2023 12:47:52 +0100 David Hildenbrand wrote: Checking whether the memory regions are equal is sufficient: if they are equal, then most certainly the contained fd is equal. sounds

Re: [PATCH v1 2/2] vhost: Remove vhost_backend_can_merge() callback

2023-03-07 Thread Igor Mammedov
On Tue, 7 Mar 2023 11:25:48 +0100 Igor Mammedov wrote: > On Thu, 16 Feb 2023 12:47:52 +0100 > David Hildenbrand wrote: > > > Checking whether the memory regions are equal is sufficient: if they are > > equal, then most certainly the contained fd is equal. > sounds reasonable to me. > > > >

Re: [PATCH v1 2/2] vhost: Remove vhost_backend_can_merge() callback

2023-03-07 Thread Igor Mammedov
On Thu, 16 Feb 2023 12:47:52 +0100 David Hildenbrand wrote: > Checking whether the memory regions are equal is sufficient: if they are > equal, then most certainly the contained fd is equal. sounds reasonable to me. > > The whole vhost-user memslot handling is suboptimal and overly >

[PATCH v1 2/2] vhost: Remove vhost_backend_can_merge() callback

2023-02-16 Thread David Hildenbrand
Checking whether the memory regions are equal is sufficient: if they are equal, then most certainly the contained fd is equal. The whole vhost-user memslot handling is suboptimal and overly complicated. We shouldn't have to lookup a RAM memory regions we got notified about in