Re: [PATCH v1 2/3] linux-user: deal with address wrap for ARM_COMMPAGE on 32 bit

2020-06-05 Thread Alex Bennée
Alex Bennée writes: > Richard Henderson writes: > >> On 5/27/20 3:05 AM, Alex Bennée wrote: >>> @@ -2145,7 +2145,7 @@ static uintptr_t pgd_find_hole_fallback(uintptr_t >>> guest_size, uintptr_t brk, lon >>> >>> /* Return value for guest_base, or -1 if no hole found. */ >>> static uintptr_

Re: [PATCH v1 2/3] linux-user: deal with address wrap for ARM_COMMPAGE on 32 bit

2020-06-05 Thread Alex Bennée
Richard Henderson writes: > On 5/27/20 3:05 AM, Alex Bennée wrote: >> @@ -2145,7 +2145,7 @@ static uintptr_t pgd_find_hole_fallback(uintptr_t >> guest_size, uintptr_t brk, lon >> >> /* Return value for guest_base, or -1 if no hole found. */ >> static uintptr_t pgb_find_hole(uintptr_t guest

Re: [PATCH v1 2/3] linux-user: deal with address wrap for ARM_COMMPAGE on 32 bit

2020-06-01 Thread Richard Henderson
On 5/27/20 3:05 AM, Alex Bennée wrote: > @@ -2145,7 +2145,7 @@ static uintptr_t pgd_find_hole_fallback(uintptr_t > guest_size, uintptr_t brk, lon > > /* Return value for guest_base, or -1 if no hole found. */ > static uintptr_t pgb_find_hole(uintptr_t guest_loaddr, uintptr_t guest_size, > -

Re: [PATCH v1 2/3] linux-user: deal with address wrap for ARM_COMMPAGE on 32 bit

2020-05-27 Thread Alex Bennée
Aleksandar Markovic writes: > сре, 27. мај 2020. у 14:05 Aleksandar Markovic > је написао/ла: >> >> сре, 27. мај 2020. у 12:07 Alex Bennée је >> написао/ла: >> > >> > We rely on the pointer to wrap when accessing the high address of the >> > COMMPAGE so it lands somewhere reasonable. However

Re: [PATCH v1 2/3] linux-user: deal with address wrap for ARM_COMMPAGE on 32 bit

2020-05-27 Thread Aleksandar Markovic
сре, 27. мај 2020. у 14:05 Aleksandar Markovic је написао/ла: > > сре, 27. мај 2020. у 12:07 Alex Bennée је написао/ла: > > > > We rely on the pointer to wrap when accessing the high address of the > > COMMPAGE so it lands somewhere reasonable. However on 32 bit hosts we > > cannot afford just to

Re: [PATCH v1 2/3] linux-user: deal with address wrap for ARM_COMMPAGE on 32 bit

2020-05-27 Thread Aleksandar Markovic
сре, 27. мај 2020. у 12:07 Alex Bennée је написао/ла: > > We rely on the pointer to wrap when accessing the high address of the > COMMPAGE so it lands somewhere reasonable. However on 32 bit hosts we > cannot afford just to map the entire 4gb address range. The old mmap > trial and error code hand

[PATCH v1 2/3] linux-user: deal with address wrap for ARM_COMMPAGE on 32 bit

2020-05-27 Thread Alex Bennée
We rely on the pointer to wrap when accessing the high address of the COMMPAGE so it lands somewhere reasonable. However on 32 bit hosts we cannot afford just to map the entire 4gb address range. The old mmap trial and error code handled this by just checking we could map both the guest_base and th