Re: [PATCH v10 00/17] qapi: net: add unix socket type support to netdev backend

2022-10-11 Thread Jason Wang
On Wed, Oct 12, 2022 at 4:05 AM Laurent Vivier wrote: > > On 10/9/22 07:52, Jason Wang wrote: > > On Thu, Oct 6, 2022 at 7:21 PM Michael S. Tsirkin wrote: > >> > >> On Wed, Oct 05, 2022 at 06:20:34PM +0200, Laurent Vivier wrote: > >>> "-netdev socket" only supports inet sockets. > >>> > >>> It's

Re: [PATCH v10 00/17] qapi: net: add unix socket type support to netdev backend

2022-10-11 Thread Laurent Vivier
On 10/9/22 07:52, Jason Wang wrote: On Thu, Oct 6, 2022 at 7:21 PM Michael S. Tsirkin wrote: On Wed, Oct 05, 2022 at 06:20:34PM +0200, Laurent Vivier wrote: "-netdev socket" only supports inet sockets. It's not a complex task to add support for unix sockets, but the socket netdev parameters

Re: [PATCH v10 00/17] qapi: net: add unix socket type support to netdev backend

2022-10-08 Thread Jason Wang
On Thu, Oct 6, 2022 at 7:21 PM Michael S. Tsirkin wrote: > > On Wed, Oct 05, 2022 at 06:20:34PM +0200, Laurent Vivier wrote: > > "-netdev socket" only supports inet sockets. > > > > It's not a complex task to add support for unix sockets, but > > the socket netdev parameters are not defined to man

Re: [PATCH v10 00/17] qapi: net: add unix socket type support to netdev backend

2022-10-06 Thread Michael S. Tsirkin
On Wed, Oct 05, 2022 at 06:20:34PM +0200, Laurent Vivier wrote: > "-netdev socket" only supports inet sockets. > > It's not a complex task to add support for unix sockets, but > the socket netdev parameters are not defined to manage well unix > socket parameters. Looks good. Acked-by: Michael S.

[PATCH v10 00/17] qapi: net: add unix socket type support to netdev backend

2022-10-05 Thread Laurent Vivier
"-netdev socket" only supports inet sockets. It's not a complex task to add support for unix sockets, but the socket netdev parameters are not defined to manage well unix socket parameters. As discussed in: "socket.c added support for unix domain socket datagram transport" https://lore.kern