Re: [PATCH v10 06/12] pcie_sriov: Reuse SR-IOV VF device instances

2024-07-20 Thread Michael S. Tsirkin
On Sat, Jul 13, 2024 at 09:45:07PM +0900, Akihiko Odaki wrote: > On 2024/07/10 19:52, Michael S. Tsirkin wrote: > > On Wed, Jul 10, 2024 at 08:37:27AM +0200, Cédric Le Goater wrote: > > > Hello, > > > > > > This change introduced a regression on s390x. I could have spotted it > > > earlier. Sorry

Re: [PATCH v10 06/12] pcie_sriov: Reuse SR-IOV VF device instances

2024-07-13 Thread Akihiko Odaki
On 2024/07/10 19:52, Michael S. Tsirkin wrote: On Wed, Jul 10, 2024 at 08:37:27AM +0200, Cédric Le Goater wrote: Hello, This change introduced a regression on s390x. I could have spotted it earlier. Sorry about that. Here is the scenario, QEMU now creates automatically the PCI device objects r

Re: [PATCH v10 06/12] pcie_sriov: Reuse SR-IOV VF device instances

2024-07-10 Thread Michael S. Tsirkin
On Wed, Jul 10, 2024 at 08:37:27AM +0200, Cédric Le Goater wrote: > Hello, > > This change introduced a regression on s390x. I could have spotted it > earlier. Sorry about that. Here is the scenario, > > QEMU now creates automatically the PCI device objects representing the > VFs when the PF devi

Re: [PATCH v10 06/12] pcie_sriov: Reuse SR-IOV VF device instances

2024-07-09 Thread Cédric Le Goater
Hello, This change introduced a regression on s390x. I could have spotted it earlier. Sorry about that. Here is the scenario, QEMU now creates automatically the PCI device objects representing the VFs when the PF device is realized in pcie_sriov_pf_init(). This is good to report errors early but

[PATCH v10 06/12] pcie_sriov: Reuse SR-IOV VF device instances

2024-06-26 Thread Akihiko Odaki
Disable SR-IOV VF devices by reusing code to power down PCI devices instead of removing them when the guest requests to disable VFs. This allows to realize devices and report VF realization errors at PF realization time. Signed-off-by: Akihiko Odaki --- include/hw/pci/pci.h| 5 --- incl