Re: [PATCH v10 6/9] KVM: Unmap existing mappings when change the memory attributes

2023-01-13 Thread Sean Christopherson
On Fri, Dec 02, 2022, Chao Peng wrote: > @@ -785,11 +786,12 @@ struct kvm { > > #if defined(CONFIG_MMU_NOTIFIER) && defined(KVM_ARCH_WANT_MMU_NOTIFIER) > struct mmu_notifier mmu_notifier; > +#endif > unsigned long mmu_invalidate_seq; > long mmu_invalidate_in_progress; > g

Re: [PATCH v10 6/9] KVM: Unmap existing mappings when change the memory attributes

2022-12-18 Thread Chao Peng
On Tue, Dec 13, 2022 at 11:51:25PM +, Huang, Kai wrote: > On Fri, 2022-12-02 at 14:13 +0800, Chao Peng wrote: > >   > > - /* flags is currently not used. */ > > + /* 'flags' is currently not used. */ > >   if (attrs->flags) > >   return -EINVAL; > > Unintended code change. Yea

Re: [PATCH v10 6/9] KVM: Unmap existing mappings when change the memory attributes

2022-12-13 Thread Huang, Kai
On Fri, 2022-12-02 at 14:13 +0800, Chao Peng wrote: >   > - /* flags is currently not used. */ > + /* 'flags' is currently not used. */ >   if (attrs->flags) >   return -EINVAL; Unintended code change.

Re: [PATCH v10 6/9] KVM: Unmap existing mappings when change the memory attributes

2022-12-11 Thread Chao Peng
On Fri, Dec 09, 2022 at 08:57:31AM +, Fuad Tabba wrote: > Hi, > > On Thu, Dec 8, 2022 at 11:18 AM Chao Peng wrote: > > > > On Wed, Dec 07, 2022 at 05:16:34PM +, Fuad Tabba wrote: > > > Hi, > > > > > > On Fri, Dec 2, 2022 at 6:19 AM Chao Peng > > > wrote: > > > > > > > > Unmap the existi

Re: [PATCH v10 6/9] KVM: Unmap existing mappings when change the memory attributes

2022-12-09 Thread Fuad Tabba
Hi, On Thu, Dec 8, 2022 at 11:18 AM Chao Peng wrote: > > On Wed, Dec 07, 2022 at 05:16:34PM +, Fuad Tabba wrote: > > Hi, > > > > On Fri, Dec 2, 2022 at 6:19 AM Chao Peng > > wrote: > > > > > > Unmap the existing guest mappings when memory attribute is changed > > > between shared and privat

Re: [PATCH v10 6/9] KVM: Unmap existing mappings when change the memory attributes

2022-12-08 Thread Yuan Yao
On Thu, Dec 08, 2022 at 07:20:43PM +0800, Chao Peng wrote: > On Wed, Dec 07, 2022 at 04:13:14PM +0800, Yuan Yao wrote: > > On Fri, Dec 02, 2022 at 02:13:44PM +0800, Chao Peng wrote: > > > Unmap the existing guest mappings when memory attribute is changed > > > between shared and private. This is ne

Re: [PATCH v10 6/9] KVM: Unmap existing mappings when change the memory attributes

2022-12-08 Thread Chao Peng
On Wed, Dec 07, 2022 at 04:13:14PM +0800, Yuan Yao wrote: > On Fri, Dec 02, 2022 at 02:13:44PM +0800, Chao Peng wrote: > > Unmap the existing guest mappings when memory attribute is changed > > between shared and private. This is needed because shared pages and > > private pages are from different

Re: [PATCH v10 6/9] KVM: Unmap existing mappings when change the memory attributes

2022-12-08 Thread Chao Peng
On Wed, Dec 07, 2022 at 05:16:34PM +, Fuad Tabba wrote: > Hi, > > On Fri, Dec 2, 2022 at 6:19 AM Chao Peng wrote: > > > > Unmap the existing guest mappings when memory attribute is changed > > between shared and private. This is needed because shared pages and > > private pages are from diffe

Re: [PATCH v10 6/9] KVM: Unmap existing mappings when change the memory attributes

2022-12-07 Thread Fuad Tabba
Hi, On Fri, Dec 2, 2022 at 6:19 AM Chao Peng wrote: > > Unmap the existing guest mappings when memory attribute is changed > between shared and private. This is needed because shared pages and > private pages are from different backends, unmapping existing ones > gives a chance for page fault han

Re: [PATCH v10 6/9] KVM: Unmap existing mappings when change the memory attributes

2022-12-07 Thread Yuan Yao
On Fri, Dec 02, 2022 at 02:13:44PM +0800, Chao Peng wrote: > Unmap the existing guest mappings when memory attribute is changed > between shared and private. This is needed because shared pages and > private pages are from different backends, unmapping existing ones > gives a chance for page fault

[PATCH v10 6/9] KVM: Unmap existing mappings when change the memory attributes

2022-12-01 Thread Chao Peng
Unmap the existing guest mappings when memory attribute is changed between shared and private. This is needed because shared pages and private pages are from different backends, unmapping existing ones gives a chance for page fault handler to re-populate the mappings according to the new attribute.