Re: [PATCH v10 Kernel 1/5] vfio: KABI for migration interface for device state

2020-01-10 Thread Cornelia Huck
On Wed, 8 Jan 2020 15:44:28 -0700 Alex Williamson wrote: > On Thu, 9 Jan 2020 02:11:11 +0530 > Kirti Wankhede wrote: > > > On 1/9/2020 12:01 AM, Alex Williamson wrote: > > > On Wed, 8 Jan 2020 15:59:55 +0100 > > > Cornelia Huck wrote: > > >> I think one thing we could do is start to tie the

Re: [PATCH v10 Kernel 1/5] vfio: KABI for migration interface for device state

2020-01-08 Thread Alex Williamson
On Thu, 9 Jan 2020 02:11:11 +0530 Kirti Wankhede wrote: > On 1/9/2020 12:01 AM, Alex Williamson wrote: > > On Wed, 8 Jan 2020 15:59:55 +0100 > > Cornelia Huck wrote: > > > >> On Tue, 7 Jan 2020 11:56:02 -0700 > >> Alex Williamson wrote: > >> > >>> On Tue, 7 Jan 2020 23:23:17 +0530 > >>> Ki

Re: [PATCH v10 Kernel 1/5] vfio: KABI for migration interface for device state

2020-01-08 Thread Kirti Wankhede
On 1/9/2020 12:01 AM, Alex Williamson wrote: On Wed, 8 Jan 2020 15:59:55 +0100 Cornelia Huck wrote: On Tue, 7 Jan 2020 11:56:02 -0700 Alex Williamson wrote: On Tue, 7 Jan 2020 23:23:17 +0530 Kirti Wankhede wrote: There are 3 invalid states: * 101b => Invalid state * 110b => I

Re: [PATCH v10 Kernel 1/5] vfio: KABI for migration interface for device state

2020-01-08 Thread Alex Williamson
On Wed, 8 Jan 2020 15:59:55 +0100 Cornelia Huck wrote: > On Tue, 7 Jan 2020 11:56:02 -0700 > Alex Williamson wrote: > > > On Tue, 7 Jan 2020 23:23:17 +0530 > > Kirti Wankhede wrote: > > > > There are 3 invalid states: > > > * 101b => Invalid state > > > * 110b => Invalid state > > >

Re: [PATCH v10 Kernel 1/5] vfio: KABI for migration interface for device state

2020-01-08 Thread Cornelia Huck
On Tue, 7 Jan 2020 11:56:02 -0700 Alex Williamson wrote: > On Tue, 7 Jan 2020 23:23:17 +0530 > Kirti Wankhede wrote: > > There are 3 invalid states: > > * 101b => Invalid state > > * 110b => Invalid state > > * 111b => Invalid state > > > > why only 110b should be used to report error

Re: [PATCH v10 Kernel 1/5] vfio: KABI for migration interface for device state

2020-01-07 Thread Alex Williamson
On Tue, 7 Jan 2020 23:23:17 +0530 Kirti Wankhede wrote: > On 1/7/2020 10:39 PM, Alex Williamson wrote: > > On Tue, 7 Jan 2020 12:58:22 +0530 > > Kirti Wankhede wrote: > > > >> On 1/7/2020 4:48 AM, Alex Williamson wrote: > >>> On Thu, 2 Jan 2020 18:25:37 + > >>> "Dr. David Alan Gilbert"

Re: [PATCH v10 Kernel 1/5] vfio: KABI for migration interface for device state

2020-01-07 Thread Kirti Wankhede
On 1/7/2020 10:39 PM, Alex Williamson wrote: On Tue, 7 Jan 2020 12:58:22 +0530 Kirti Wankhede wrote: On 1/7/2020 4:48 AM, Alex Williamson wrote: On Thu, 2 Jan 2020 18:25:37 + "Dr. David Alan Gilbert" wrote: * Alex Williamson (alex.william...@redhat.com) wrote: On Fri, 20 Dec 201

Re: [PATCH v10 Kernel 1/5] vfio: KABI for migration interface for device state

2020-01-07 Thread Dr. David Alan Gilbert
* Alex Williamson (alex.william...@redhat.com) wrote: > On Tue, 7 Jan 2020 09:57:40 + > "Dr. David Alan Gilbert" wrote: > > > * Alex Williamson (alex.william...@redhat.com) wrote: > > > On Thu, 2 Jan 2020 18:25:37 + > > > "Dr. David Alan Gilbert" wrote: > > > > > > > * Alex Williamson

Re: [PATCH v10 Kernel 1/5] vfio: KABI for migration interface for device state

2020-01-07 Thread Alex Williamson
On Tue, 7 Jan 2020 12:58:22 +0530 Kirti Wankhede wrote: > On 1/7/2020 4:48 AM, Alex Williamson wrote: > > On Thu, 2 Jan 2020 18:25:37 + > > "Dr. David Alan Gilbert" wrote: > > > >> * Alex Williamson (alex.william...@redhat.com) wrote: > >>> On Fri, 20 Dec 2019 01:40:35 +0530 > >>> Kirti

Re: [PATCH v10 Kernel 1/5] vfio: KABI for migration interface for device state

2020-01-07 Thread Alex Williamson
On Tue, 7 Jan 2020 09:57:40 + "Dr. David Alan Gilbert" wrote: > * Alex Williamson (alex.william...@redhat.com) wrote: > > On Thu, 2 Jan 2020 18:25:37 + > > "Dr. David Alan Gilbert" wrote: > > > > > * Alex Williamson (alex.william...@redhat.com) wrote: > > > > On Fri, 20 Dec 2019 01:

Re: [PATCH v10 Kernel 1/5] vfio: KABI for migration interface for device state

2020-01-07 Thread Dr. David Alan Gilbert
* Alex Williamson (alex.william...@redhat.com) wrote: > On Thu, 2 Jan 2020 18:25:37 + > "Dr. David Alan Gilbert" wrote: > > > * Alex Williamson (alex.william...@redhat.com) wrote: > > > On Fri, 20 Dec 2019 01:40:35 +0530 > > > Kirti Wankhede wrote: > > > > > > > On 12/19/2019 10:57 PM, Al

Re: [PATCH v10 Kernel 1/5] vfio: KABI for migration interface for device state

2020-01-06 Thread Kirti Wankhede
On 1/7/2020 4:48 AM, Alex Williamson wrote: On Thu, 2 Jan 2020 18:25:37 + "Dr. David Alan Gilbert" wrote: * Alex Williamson (alex.william...@redhat.com) wrote: On Fri, 20 Dec 2019 01:40:35 +0530 Kirti Wankhede wrote: On 12/19/2019 10:57 PM, Alex Williamson wrote: If d

Re: [PATCH v10 Kernel 1/5] vfio: KABI for migration interface for device state

2020-01-06 Thread Alex Williamson
On Thu, 2 Jan 2020 18:25:37 + "Dr. David Alan Gilbert" wrote: > * Alex Williamson (alex.william...@redhat.com) wrote: > > On Fri, 20 Dec 2019 01:40:35 +0530 > > Kirti Wankhede wrote: > > > > > On 12/19/2019 10:57 PM, Alex Williamson wrote: > > > > > > > > > > > > > > > > > > If d

Re: [PATCH v10 Kernel 1/5] vfio: KABI for migration interface for device state

2020-01-02 Thread Dr. David Alan Gilbert
* Alex Williamson (alex.william...@redhat.com) wrote: > On Fri, 20 Dec 2019 01:40:35 +0530 > Kirti Wankhede wrote: > > > On 12/19/2019 10:57 PM, Alex Williamson wrote: > > > > > > > > > > If device state it at pre-copy state (011b). > > Transition, i.e., write to device state as stop-and-c

Re: [PATCH v10 Kernel 1/5] vfio: KABI for migration interface for device state

2019-12-19 Thread Alex Williamson
On Fri, 20 Dec 2019 01:40:35 +0530 Kirti Wankhede wrote: > On 12/19/2019 10:57 PM, Alex Williamson wrote: > > > > > >> + * 2. When VFIO application save state or suspend application, VFIO > >> device > >> + *state transition is from _RUNNING to stop-and-copy state and >

Re: [PATCH v10 Kernel 1/5] vfio: KABI for migration interface for device state

2019-12-19 Thread Kirti Wankhede
On 12/19/2019 10:57 PM, Alex Williamson wrote: + * 2. When VFIO application save state or suspend application, VFIO device + *state transition is from _RUNNING to stop-and-copy state and then to + *_STOP. + *On state transition from _RUNNING to stop-and-copy, driver must + *

Re: [PATCH v10 Kernel 1/5] vfio: KABI for migration interface for device state

2019-12-19 Thread Alex Williamson
On Thu, 19 Dec 2019 21:38:44 +0530 Kirti Wankhede wrote: > On 12/18/2019 12:13 AM, Alex Williamson wrote: > > On Tue, 17 Dec 2019 11:58:44 +0530 > > Kirti Wankhede wrote: > > > >> On 12/17/2019 4:14 AM, Alex Williamson wrote: > >>> On Tue, 17 Dec 2019 01:51:36 +0530 > >>> Kirti Wankhede wr

Re: [PATCH v10 Kernel 1/5] vfio: KABI for migration interface for device state

2019-12-19 Thread Kirti Wankhede
On 12/18/2019 12:13 AM, Alex Williamson wrote: On Tue, 17 Dec 2019 11:58:44 +0530 Kirti Wankhede wrote: On 12/17/2019 4:14 AM, Alex Williamson wrote: On Tue, 17 Dec 2019 01:51:36 +0530 Kirti Wankhede wrote: - Defined MIGRATION region type and sub-type. - Defined vfio_device_migratio

Re: [PATCH v10 Kernel 1/5] vfio: KABI for migration interface for device state

2019-12-17 Thread Alex Williamson
On Tue, 17 Dec 2019 11:58:44 +0530 Kirti Wankhede wrote: > On 12/17/2019 4:14 AM, Alex Williamson wrote: > > On Tue, 17 Dec 2019 01:51:36 +0530 > > Kirti Wankhede wrote: > > > >> - Defined MIGRATION region type and sub-type. > >> > >> - Defined vfio_device_migration_info structure which will

Re: [PATCH v10 Kernel 1/5] vfio: KABI for migration interface for device state

2019-12-16 Thread Yan Zhao
On Tue, Dec 17, 2019 at 02:28:44PM +0800, Kirti Wankhede wrote: > > > On 12/17/2019 4:14 AM, Alex Williamson wrote: > > On Tue, 17 Dec 2019 01:51:36 +0530 > > Kirti Wankhede wrote: > > > >> - Defined MIGRATION region type and sub-type. > >> > >> - Defined vfio_device_migration_info structure wh

Re: [PATCH v10 Kernel 1/5] vfio: KABI for migration interface for device state

2019-12-16 Thread Kirti Wankhede
On 12/17/2019 4:14 AM, Alex Williamson wrote: On Tue, 17 Dec 2019 01:51:36 +0530 Kirti Wankhede wrote: - Defined MIGRATION region type and sub-type. - Defined vfio_device_migration_info structure which will be placed at 0th offset of migration region to get/set VFIO device related infor

Re: [PATCH v10 Kernel 1/5] vfio: KABI for migration interface for device state

2019-12-16 Thread Alex Williamson
On Tue, 17 Dec 2019 01:51:36 +0530 Kirti Wankhede wrote: > - Defined MIGRATION region type and sub-type. > > - Defined vfio_device_migration_info structure which will be placed at 0th > offset of migration region to get/set VFIO device related information. > Defined members of structure and

[PATCH v10 Kernel 1/5] vfio: KABI for migration interface for device state

2019-12-16 Thread Kirti Wankhede
- Defined MIGRATION region type and sub-type. - Defined vfio_device_migration_info structure which will be placed at 0th offset of migration region to get/set VFIO device related information. Defined members of structure and usage on read/write access. - Defined device states and added state