Re: [PATCH v11 18/25] cpu: Move synchronize_from_tb() to tcg_ops

2020-12-14 Thread Eduardo Habkost
On Sat, Dec 12, 2020 at 11:00:03AM +0100, Claudio Fontana wrote: > On 12/11/20 9:02 PM, Eduardo Habkost wrote: > > On Fri, Dec 11, 2020 at 07:51:54PM +0100, Claudio Fontana wrote: > >> On 12/11/20 7:26 PM, Philippe Mathieu-Daudé wrote: > >>> On 12/11/20 7:22 PM, Richard Henderson wrote: > On

Re: [PATCH v11 18/25] cpu: Move synchronize_from_tb() to tcg_ops

2020-12-12 Thread Claudio Fontana
On 12/12/20 11:00 AM, Claudio Fontana wrote: > On 12/11/20 9:02 PM, Eduardo Habkost wrote: >> On Fri, Dec 11, 2020 at 07:51:54PM +0100, Claudio Fontana wrote: >>> On 12/11/20 7:26 PM, Philippe Mathieu-Daudé wrote: On 12/11/20 7:22 PM, Richard Henderson wrote: > On 12/11/20 12:15 PM,

Re: [PATCH v11 18/25] cpu: Move synchronize_from_tb() to tcg_ops

2020-12-12 Thread Claudio Fontana
On 12/11/20 9:02 PM, Eduardo Habkost wrote: > On Fri, Dec 11, 2020 at 07:51:54PM +0100, Claudio Fontana wrote: >> On 12/11/20 7:26 PM, Philippe Mathieu-Daudé wrote: >>> On 12/11/20 7:22 PM, Richard Henderson wrote: On 12/11/20 12:15 PM, Claudio Fontana wrote: > Should I return this file

Re: [PATCH v11 18/25] cpu: Move synchronize_from_tb() to tcg_ops

2020-12-11 Thread Eduardo Habkost
On Fri, Dec 11, 2020 at 07:51:54PM +0100, Claudio Fontana wrote: > On 12/11/20 7:26 PM, Philippe Mathieu-Daudé wrote: > > On 12/11/20 7:22 PM, Richard Henderson wrote: > >> On 12/11/20 12:15 PM, Claudio Fontana wrote: > >>> Should I return this file to the original state (without the extra > >>>

Re: [PATCH v11 18/25] cpu: Move synchronize_from_tb() to tcg_ops

2020-12-11 Thread Philippe Mathieu-Daudé
On 12/11/20 7:51 PM, Claudio Fontana wrote: > On 12/11/20 7:26 PM, Philippe Mathieu-Daudé wrote: >> On 12/11/20 7:22 PM, Richard Henderson wrote: >>> On 12/11/20 12:15 PM, Claudio Fontana wrote: Should I return this file to the original state (without the extra #includes that pretend it

Re: [PATCH v11 18/25] cpu: Move synchronize_from_tb() to tcg_ops

2020-12-11 Thread Claudio Fontana
On 12/11/20 7:26 PM, Philippe Mathieu-Daudé wrote: > On 12/11/20 7:22 PM, Richard Henderson wrote: >> On 12/11/20 12:15 PM, Claudio Fontana wrote: >>> Should I return this file to the original state (without the extra >>> #includes that pretend it to be a standalone header file, >>> and call it

Re: [PATCH v11 18/25] cpu: Move synchronize_from_tb() to tcg_ops

2020-12-11 Thread Philippe Mathieu-Daudé
On 12/11/20 7:22 PM, Richard Henderson wrote: > On 12/11/20 12:15 PM, Claudio Fontana wrote: >> Should I return this file to the original state (without the extra #includes >> that pretend it to be a standalone header file, >> and call it >> >> tcg-cpu-ops.h.inc >> >> ? > > If this header can

Re: [PATCH v11 18/25] cpu: Move synchronize_from_tb() to tcg_ops

2020-12-11 Thread Richard Henderson
On 12/11/20 12:15 PM, Claudio Fontana wrote: > Should I return this file to the original state (without the extra #includes > that pretend it to be a standalone header file, > and call it > > tcg-cpu-ops.h.inc > > ? If this header can work with qemu/typedefs.h, then no, because the circularity

Re: [PATCH v11 18/25] cpu: Move synchronize_from_tb() to tcg_ops

2020-12-11 Thread Richard Henderson
On 12/11/20 11:47 AM, Claudio Fontana wrote: >> What is it that you thought you needed from core/cpu.h anyway? ... Are you sure that splitting out hw/core/tcg-cpu-ops.h from hw/core/cpu.h in patch 15 is even useful? >>> >>> it avoids a huge #ifdef CONFIG_TCG >> >> So? The question

Re: [PATCH v11 18/25] cpu: Move synchronize_from_tb() to tcg_ops

2020-12-11 Thread Claudio Fontana
On 12/11/20 6:28 PM, Richard Henderson wrote: > On 12/11/20 11:10 AM, Claudio Fontana wrote: >> On 12/11/20 6:05 PM, Richard Henderson wrote: >>> On 12/11/20 2:31 AM, Claudio Fontana wrote: From: Eduardo Habkost Signed-off-by: Eduardo Habkost [claudio: wrapped in CONFIG_TCG]

Re: [PATCH v11 18/25] cpu: Move synchronize_from_tb() to tcg_ops

2020-12-11 Thread Claudio Fontana
On 12/11/20 6:47 PM, Claudio Fontana wrote: > On 12/11/20 6:28 PM, Richard Henderson wrote: >> On 12/11/20 11:10 AM, Claudio Fontana wrote: >>> On 12/11/20 6:05 PM, Richard Henderson wrote: On 12/11/20 2:31 AM, Claudio Fontana wrote: > From: Eduardo Habkost > > Signed-off-by:

Re: [PATCH v11 18/25] cpu: Move synchronize_from_tb() to tcg_ops

2020-12-11 Thread Richard Henderson
On 12/11/20 11:10 AM, Claudio Fontana wrote: > On 12/11/20 6:05 PM, Richard Henderson wrote: >> On 12/11/20 2:31 AM, Claudio Fontana wrote: >>> From: Eduardo Habkost >>> >>> Signed-off-by: Eduardo Habkost >>> [claudio: wrapped in CONFIG_TCG] >>> Signed-off-by: Claudio Fontana >>> Reviewed-by:

Re: [PATCH v11 18/25] cpu: Move synchronize_from_tb() to tcg_ops

2020-12-11 Thread Claudio Fontana
On 12/11/20 6:05 PM, Richard Henderson wrote: > On 12/11/20 2:31 AM, Claudio Fontana wrote: >> From: Eduardo Habkost >> >> Signed-off-by: Eduardo Habkost >> [claudio: wrapped in CONFIG_TCG] >> Signed-off-by: Claudio Fontana >> Reviewed-by: Philippe Mathieu-Daudé >> Reviewed-by: Alex Bennée >>

Re: [PATCH v11 18/25] cpu: Move synchronize_from_tb() to tcg_ops

2020-12-11 Thread Claudio Fontana
On 12/11/20 6:10 PM, Claudio Fontana wrote: > On 12/11/20 6:05 PM, Richard Henderson wrote: >> On 12/11/20 2:31 AM, Claudio Fontana wrote: >>> From: Eduardo Habkost >>> >>> Signed-off-by: Eduardo Habkost >>> [claudio: wrapped in CONFIG_TCG] >>> Signed-off-by: Claudio Fontana >>> Reviewed-by:

Re: [PATCH v11 18/25] cpu: Move synchronize_from_tb() to tcg_ops

2020-12-11 Thread Richard Henderson
On 12/11/20 2:31 AM, Claudio Fontana wrote: > From: Eduardo Habkost > > Signed-off-by: Eduardo Habkost > [claudio: wrapped in CONFIG_TCG] > Signed-off-by: Claudio Fontana > Reviewed-by: Philippe Mathieu-Daudé > Reviewed-by: Alex Bennée > --- > include/hw/core/cpu.h | 8 >

[PATCH v11 18/25] cpu: Move synchronize_from_tb() to tcg_ops

2020-12-11 Thread Claudio Fontana
From: Eduardo Habkost Signed-off-by: Eduardo Habkost [claudio: wrapped in CONFIG_TCG] Signed-off-by: Claudio Fontana Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- include/hw/core/cpu.h | 8 include/hw/core/tcg-cpu-ops.h | 12