Re: [PATCH v11 2/2] docs: qcow2: introduce compression type feature

2020-02-06 Thread Eric Blake
On 2/6/20 6:38 AM, Max Reitz wrote: I'm OK with it too, as well as I'm OK with the stricter variant, when we don't allow incompatible images with zlib set. I don't see any serious difference. But I need this to land somehow. Max likes stricter variant and he is maintainer of qcow2.. Max, will

Re: [PATCH v11 2/2] docs: qcow2: introduce compression type feature

2020-02-06 Thread Max Reitz
On 31.01.20 19:15, Vladimir Sementsov-Ogievskiy wrote: > 31.01.2020 20:49, Eric Blake wrote: >> On 1/31/20 11:34 AM, Alberto Garcia wrote: >>> On Fri 31 Jan 2020 03:46:12 PM CET, Eric Blake wrote: > +    If the incompatible bit "Compression type" is > set: the field > + 

Re: [PATCH v11 2/2] docs: qcow2: introduce compression type feature

2020-01-31 Thread Alberto Garcia
On Fri 31 Jan 2020 07:15:33 PM CET, Vladimir Sementsov-Ogievskiy wrote: > I'm OK with it too, as well as I'm OK with the stricter variant, when > we don't allow incompatible images with zlib set. I don't see any > serious difference. I also think both options are fine. Berto

Re: [PATCH v11 2/2] docs: qcow2: introduce compression type feature

2020-01-31 Thread Vladimir Sementsov-Ogievskiy
31.01.2020 20:49, Eric Blake wrote: On 1/31/20 11:34 AM, Alberto Garcia wrote: On Fri 31 Jan 2020 03:46:12 PM CET, Eric Blake wrote: +    If the incompatible bit "Compression type" is set: the field +    must be present and non-zero (which means non-zlib +  

Re: [PATCH v11 2/2] docs: qcow2: introduce compression type feature

2020-01-31 Thread Eric Blake
On 1/31/20 11:34 AM, Alberto Garcia wrote: On Fri 31 Jan 2020 03:46:12 PM CET, Eric Blake wrote: +If the incompatible bit "Compression type" is set: the field +must be present and non-zero (which means non-zlib +compression type). Othe

Re: [PATCH v11 2/2] docs: qcow2: introduce compression type feature

2020-01-31 Thread Alberto Garcia
On Fri 31 Jan 2020 03:46:12 PM CET, Eric Blake wrote: >> +If the incompatible bit "Compression type" is set: the >> field >> +must be present and non-zero (which means non-zlib >> +compression type). Otherwise, this field must not be >>

Re: [PATCH v11 2/2] docs: qcow2: introduce compression type feature

2020-01-31 Thread Eric Blake
On 1/31/20 8:22 AM, Vladimir Sementsov-Ogievskiy wrote: The patch adds a new additional field to the qcow2 header: compression_type, which specifies compression type. If field is absent or zero, default compression type is set: ZLIB, which corresponds to current behavior. New compression type (Z

[PATCH v11 2/2] docs: qcow2: introduce compression type feature

2020-01-31 Thread Vladimir Sementsov-Ogievskiy
The patch adds a new additional field to the qcow2 header: compression_type, which specifies compression type. If field is absent or zero, default compression type is set: ZLIB, which corresponds to current behavior. New compression type (ZSTD) is to be added in further commit. Suggested-by: Deni