Re: [PATCH v11 7/8] nbd: introduce ERRP_AUTO_PROPAGATE

2020-07-07 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > If we want to add some info to errp (by error_prepend() or > error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. > Otherwise, this info will not be added when errp == &error_fatal Same for &error_abort, but to fix that, ERRP_AUTO_PROPAGATE() wo

Re: [PATCH v11 7/8] nbd: introduce ERRP_AUTO_PROPAGATE

2020-07-05 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > If we want to add some info to errp (by error_prepend() or > error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. > Otherwise, this info will not be added when errp == &error_fatal > (the program will exit prior to the error_append_hint() or > er

[PATCH v11 7/8] nbd: introduce ERRP_AUTO_PROPAGATE

2020-07-03 Thread Vladimir Sementsov-Ogievskiy
If we want to add some info to errp (by error_prepend() or error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. Otherwise, this info will not be added when errp == &error_fatal (the program will exit prior to the error_append_hint() or error_prepend() call). Fix such cases. If we want