Re: [PATCH v14 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-19 Thread Yan Zhao
On Fri, Mar 20, 2020 at 12:57:30AM +0800, Kirti Wankhede wrote: > > > On 3/19/2020 6:36 PM, Alex Williamson wrote: > > On Thu, 19 Mar 2020 02:15:34 -0400 > > Yan Zhao wrote: > > > >> On Thu, Mar 19, 2020 at 12:40:53PM +0800, Alex Williamson wrote: > >>> On Thu, 19 Mar 2020 00:15:33 -0400 > >>>

Re: [PATCH v14 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-19 Thread Alex Williamson
On Fri, 20 Mar 2020 01:55:10 +0530 Kirti Wankhede wrote: > On 3/19/2020 9:52 PM, Alex Williamson wrote: > > On Thu, 19 Mar 2020 20:22:41 +0530 > > Kirti Wankhede wrote: > > > >> On 3/19/2020 9:15 AM, Alex Williamson wrote: > >>> On Thu, 19 Mar 2020 01:11:11 +0530 > >>> Kirti Wankhede

Re: [PATCH v14 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-19 Thread Kirti Wankhede
On 3/19/2020 9:52 PM, Alex Williamson wrote: On Thu, 19 Mar 2020 20:22:41 +0530 Kirti Wankhede wrote: On 3/19/2020 9:15 AM, Alex Williamson wrote: On Thu, 19 Mar 2020 01:11:11 +0530 Kirti Wankhede wrote: + +static int verify_bitmap_size(uint64_t npages, uint64_t bitmap_size) +{

Re: [PATCH v14 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-19 Thread Kirti Wankhede
On 3/19/2020 9:15 AM, Alex Williamson wrote: On Thu, 19 Mar 2020 01:11:11 +0530 Kirti Wankhede wrote: VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: - Start dirty pages tracking while migration is active - Stop dirty pages tracking. - Get dirty pages bitmap. Its user space

Re: [PATCH v14 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-19 Thread Kirti Wankhede
On 3/19/2020 6:36 PM, Alex Williamson wrote: On Thu, 19 Mar 2020 02:15:34 -0400 Yan Zhao wrote: On Thu, Mar 19, 2020 at 12:40:53PM +0800, Alex Williamson wrote: On Thu, 19 Mar 2020 00:15:33 -0400 Yan Zhao wrote: On Thu, Mar 19, 2020 at 12:01:00PM +0800, Alex Williamson wrote: On

Re: [PATCH v14 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-19 Thread Alex Williamson
On Thu, 19 Mar 2020 20:22:41 +0530 Kirti Wankhede wrote: > On 3/19/2020 9:15 AM, Alex Williamson wrote: > > On Thu, 19 Mar 2020 01:11:11 +0530 > > Kirti Wankhede wrote: > > > >> VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: > >> - Start dirty pages tracking while migration is

Re: [PATCH v14 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-19 Thread Kirti Wankhede
On 3/19/2020 9:15 AM, Alex Williamson wrote: On Thu, 19 Mar 2020 01:11:11 +0530 Kirti Wankhede wrote: VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: - Start dirty pages tracking while migration is active - Stop dirty pages tracking. - Get dirty pages bitmap. Its user space

Re: [PATCH v14 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-19 Thread Alex Williamson
On Thu, 19 Mar 2020 02:15:34 -0400 Yan Zhao wrote: > On Thu, Mar 19, 2020 at 12:40:53PM +0800, Alex Williamson wrote: > > On Thu, 19 Mar 2020 00:15:33 -0400 > > Yan Zhao wrote: > > > > > On Thu, Mar 19, 2020 at 12:01:00PM +0800, Alex Williamson wrote: > > > > On Wed, 18 Mar 2020 23:06:39

Re: [PATCH v14 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-19 Thread Yan Zhao
On Thu, Mar 19, 2020 at 12:40:53PM +0800, Alex Williamson wrote: > On Thu, 19 Mar 2020 00:15:33 -0400 > Yan Zhao wrote: > > > On Thu, Mar 19, 2020 at 12:01:00PM +0800, Alex Williamson wrote: > > > On Wed, 18 Mar 2020 23:06:39 -0400 > > > Yan Zhao wrote: > > > > > > > On Thu, Mar 19, 2020 at

Re: [PATCH v14 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-18 Thread Alex Williamson
On Thu, 19 Mar 2020 00:15:33 -0400 Yan Zhao wrote: > On Thu, Mar 19, 2020 at 12:01:00PM +0800, Alex Williamson wrote: > > On Wed, 18 Mar 2020 23:06:39 -0400 > > Yan Zhao wrote: > > > > > On Thu, Mar 19, 2020 at 03:41:11AM +0800, Kirti Wankhede wrote: > > > > VFIO_IOMMU_DIRTY_PAGES ioctl

Re: [PATCH v14 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-18 Thread Yan Zhao
On Thu, Mar 19, 2020 at 12:01:00PM +0800, Alex Williamson wrote: > On Wed, 18 Mar 2020 23:06:39 -0400 > Yan Zhao wrote: > > > On Thu, Mar 19, 2020 at 03:41:11AM +0800, Kirti Wankhede wrote: > > > VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: > > > - Start dirty pages tracking while

Re: [PATCH v14 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-18 Thread Alex Williamson
On Wed, 18 Mar 2020 23:06:39 -0400 Yan Zhao wrote: > On Thu, Mar 19, 2020 at 03:41:11AM +0800, Kirti Wankhede wrote: > > VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: > > - Start dirty pages tracking while migration is active > > - Stop dirty pages tracking. > > - Get dirty pages

Re: [PATCH v14 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-18 Thread Alex Williamson
On Thu, 19 Mar 2020 01:11:11 +0530 Kirti Wankhede wrote: > VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: > - Start dirty pages tracking while migration is active > - Stop dirty pages tracking. > - Get dirty pages bitmap. Its user space application's responsibility to > copy content

Re: [PATCH v14 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-18 Thread Yan Zhao
On Thu, Mar 19, 2020 at 03:41:11AM +0800, Kirti Wankhede wrote: > VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: > - Start dirty pages tracking while migration is active > - Stop dirty pages tracking. > - Get dirty pages bitmap. Its user space application's responsibility to > copy

[PATCH v14 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-18 Thread Kirti Wankhede
VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: - Start dirty pages tracking while migration is active - Stop dirty pages tracking. - Get dirty pages bitmap. Its user space application's responsibility to copy content of dirty pages from source to destination during migration. To