Re: [PATCH v15 10/13] qapi: block-stream: add "bottom" argument

2021-01-05 Thread Max Reitz
On 22.12.20 19:00, Vladimir Sementsov-Ogievskiy wrote: 22.12.2020 19:07, Max Reitz wrote: On 16.12.20 07:17, Vladimir Sementsov-Ogievskiy wrote: The code already don't freeze base node and we try to make it prepared for the situation when base node is changed during the operation. In other word

Re: [PATCH v15 10/13] qapi: block-stream: add "bottom" argument

2020-12-22 Thread Vladimir Sementsov-Ogievskiy
22.12.2020 21:00, Vladimir Sementsov-Ogievskiy wrote: We shouldn't have use-cases when backing-fmt is set to something another than final base node. I mean, we shouldn't have use-cases when backing-file is [...] -- Best regards, Vladimir

Re: [PATCH v15 10/13] qapi: block-stream: add "bottom" argument

2020-12-22 Thread Vladimir Sementsov-Ogievskiy
22.12.2020 19:07, Max Reitz wrote: On 16.12.20 07:17, Vladimir Sementsov-Ogievskiy wrote: The code already don't freeze base node and we try to make it prepared for the situation when base node is changed during the operation. In other words, block-stream doesn't own base node. Let's introduce

Re: [PATCH v15 10/13] qapi: block-stream: add "bottom" argument

2020-12-22 Thread Max Reitz
On 16.12.20 07:17, Vladimir Sementsov-Ogievskiy wrote: The code already don't freeze base node and we try to make it prepared for the situation when base node is changed during the operation. In other words, block-stream doesn't own base node. Let's introduce a new interface which should replace

[PATCH v15 10/13] qapi: block-stream: add "bottom" argument

2020-12-15 Thread Vladimir Sementsov-Ogievskiy
The code already don't freeze base node and we try to make it prepared for the situation when base node is changed during the operation. In other words, block-stream doesn't own base node. Let's introduce a new interface which should replace the current one, which will in better relations with the