RE: [PATCH v16 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-30 Thread Zhao, Yan Y
gt; de...@nongnu.org; k...@vger.kernel.org > Subject: Re: [PATCH v16 Kernel 4/7] vfio iommu: Implementation of ioctl for > dirty pages tracking. > > On Mon, 30 Mar 2020 21:16:21 -0400 > Yan Zhao wrote: > > > On Tue, Mar 31, 2020 at 09:12:59AM +0800, Alex Williamson wro

Re: [PATCH v16 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-30 Thread Alex Williamson
On Mon, 30 Mar 2020 21:16:21 -0400 Yan Zhao wrote: > On Tue, Mar 31, 2020 at 09:12:59AM +0800, Alex Williamson wrote: > > On Mon, 30 Mar 2020 20:50:47 -0400 > > Yan Zhao wrote: > > > > > On Tue, Mar 31, 2020 at 08:53:47AM +0800, Alex Williamson wrote: > > > > On Mon, 30 Mar 2020 19:51:31 -0

Re: [PATCH v16 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-30 Thread Yan Zhao
On Tue, Mar 31, 2020 at 09:12:59AM +0800, Alex Williamson wrote: > On Mon, 30 Mar 2020 20:50:47 -0400 > Yan Zhao wrote: > > > On Tue, Mar 31, 2020 at 08:53:47AM +0800, Alex Williamson wrote: > > > On Mon, 30 Mar 2020 19:51:31 -0400 > > > Yan Zhao wrote: > > > > > > > On Mon, Mar 30, 2020 at 0

Re: [PATCH v16 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-30 Thread Alex Williamson
On Mon, 30 Mar 2020 20:50:47 -0400 Yan Zhao wrote: > On Tue, Mar 31, 2020 at 08:53:47AM +0800, Alex Williamson wrote: > > On Mon, 30 Mar 2020 19:51:31 -0400 > > Yan Zhao wrote: > > > > > On Mon, Mar 30, 2020 at 09:49:21PM +0800, Kirti Wankhede wrote: > > > > > > > > > > > > On 3/30/2020 8

Re: [PATCH v16 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-30 Thread Yan Zhao
On Tue, Mar 31, 2020 at 08:53:47AM +0800, Alex Williamson wrote: > On Mon, 30 Mar 2020 19:51:31 -0400 > Yan Zhao wrote: > > > On Mon, Mar 30, 2020 at 09:49:21PM +0800, Kirti Wankhede wrote: > > > > > > > > > On 3/30/2020 8:54 AM, Yan Zhao wrote: > > > > On Fri, Mar 27, 2020 at 01:28:13PM +080

Re: [PATCH v16 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-30 Thread Alex Williamson
On Mon, 30 Mar 2020 19:51:31 -0400 Yan Zhao wrote: > On Mon, Mar 30, 2020 at 09:49:21PM +0800, Kirti Wankhede wrote: > > > > > > On 3/30/2020 8:54 AM, Yan Zhao wrote: > > > On Fri, Mar 27, 2020 at 01:28:13PM +0800, Kirti Wankhede wrote: > > >> Hit send button little early. > > >> > > >>

Re: [PATCH v16 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-30 Thread Yan Zhao
On Mon, Mar 30, 2020 at 09:49:21PM +0800, Kirti Wankhede wrote: > > > On 3/30/2020 8:54 AM, Yan Zhao wrote: > > On Fri, Mar 27, 2020 at 01:28:13PM +0800, Kirti Wankhede wrote: > >> Hit send button little early. > >> > >> > > >> > I checked v12, it's not like what I said. > >> > In v12, bitm

Re: [PATCH v16 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-30 Thread Yan Zhao
On Tue, Mar 31, 2020 at 04:47:20AM +0800, Alex Williamson wrote: > On Sun, 29 Mar 2020 22:07:08 -0400 > Yan Zhao wrote: > > > On Fri, Mar 27, 2020 at 01:07:38PM +0800, Kirti Wankhede wrote: > > > > > > > > > On 3/27/2020 6:00 AM, Yan Zhao wrote: > > > > On Fri, Mar 27, 2020 at 05:39:01AM +080

Re: [PATCH v16 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-30 Thread Alex Williamson
On Sun, 29 Mar 2020 22:07:08 -0400 Yan Zhao wrote: > On Fri, Mar 27, 2020 at 01:07:38PM +0800, Kirti Wankhede wrote: > > > > > > On 3/27/2020 6:00 AM, Yan Zhao wrote: > > > On Fri, Mar 27, 2020 at 05:39:01AM +0800, Kirti Wankhede wrote: > > >> > > >> > > >> On 3/25/2020 7:41 AM, Yan Zhao wr

Re: [PATCH v16 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-30 Thread Kirti Wankhede
On 3/30/2020 8:54 AM, Yan Zhao wrote: On Fri, Mar 27, 2020 at 01:28:13PM +0800, Kirti Wankhede wrote: Hit send button little early. > > I checked v12, it's not like what I said. > In v12, bitmaps are generated per vfio_dma, and combination of the > bitmaps are required in order to ge

Re: [PATCH v16 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-29 Thread Yan Zhao
On Fri, Mar 27, 2020 at 01:28:13PM +0800, Kirti Wankhede wrote: > Hit send button little early. > > > > > I checked v12, it's not like what I said. > > In v12, bitmaps are generated per vfio_dma, and combination of the > > bitmaps are required in order to generate a big bitmap suiting for dirt

Re: [PATCH v16 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-29 Thread Yan Zhao
On Fri, Mar 27, 2020 at 01:07:38PM +0800, Kirti Wankhede wrote: > > > On 3/27/2020 6:00 AM, Yan Zhao wrote: > > On Fri, Mar 27, 2020 at 05:39:01AM +0800, Kirti Wankhede wrote: > >> > >> > >> On 3/25/2020 7:41 AM, Yan Zhao wrote: > >>> On Wed, Mar 25, 2020 at 05:18:52AM +0800, Kirti Wankhede wrote

Re: [PATCH v16 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-27 Thread Dr. David Alan Gilbert
* Alex Williamson (alex.william...@redhat.com) wrote: > On Fri, 27 Mar 2020 11:57:45 + > "Dr. David Alan Gilbert" wrote: > > > * Kirti Wankhede (kwankh...@nvidia.com) wrote: > > > VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: > > > - Start dirty pages tracking while migration is act

Re: [PATCH v16 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-27 Thread Alex Williamson
On Fri, 27 Mar 2020 11:57:45 + "Dr. David Alan Gilbert" wrote: > * Kirti Wankhede (kwankh...@nvidia.com) wrote: > > VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: > > - Start dirty pages tracking while migration is active > > - Stop dirty pages tracking. > > - Get dirty pages bitmap.

Re: [PATCH v16 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-27 Thread Dr. David Alan Gilbert
* Kirti Wankhede (kwankh...@nvidia.com) wrote: > VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: > - Start dirty pages tracking while migration is active > - Stop dirty pages tracking. > - Get dirty pages bitmap. Its user space application's responsibility to > copy content of dirty pages

Re: [PATCH v16 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-26 Thread Kirti Wankhede
Hit send button little early. > > I checked v12, it's not like what I said. > In v12, bitmaps are generated per vfio_dma, and combination of the > bitmaps are required in order to generate a big bitmap suiting for dirty > query. It can cause problem when offset not aligning. > But what I propose

Re: [PATCH v16 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-26 Thread Kirti Wankhede
On 3/27/2020 6:00 AM, Yan Zhao wrote: On Fri, Mar 27, 2020 at 05:39:01AM +0800, Kirti Wankhede wrote: On 3/25/2020 7:41 AM, Yan Zhao wrote: On Wed, Mar 25, 2020 at 05:18:52AM +0800, Kirti Wankhede wrote: VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: - Start dirty pages tracking

Re: [PATCH v16 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-26 Thread Yan Zhao
On Fri, Mar 27, 2020 at 05:39:01AM +0800, Kirti Wankhede wrote: > > > On 3/25/2020 7:41 AM, Yan Zhao wrote: > > On Wed, Mar 25, 2020 at 05:18:52AM +0800, Kirti Wankhede wrote: > >> VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: > >> - Start dirty pages tracking while migration is active

Re: [PATCH v16 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-26 Thread Kirti Wankhede
On 3/25/2020 7:41 AM, Yan Zhao wrote: On Wed, Mar 25, 2020 at 05:18:52AM +0800, Kirti Wankhede wrote: VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: - Start dirty pages tracking while migration is active - Stop dirty pages tracking. - Get dirty pages bitmap. Its user space applicatio

Re: [PATCH v16 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-24 Thread Yan Zhao
On Wed, Mar 25, 2020 at 05:18:52AM +0800, Kirti Wankhede wrote: > VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: > - Start dirty pages tracking while migration is active > - Stop dirty pages tracking. > - Get dirty pages bitmap. Its user space application's responsibility to > copy conte

Re: [PATCH v16 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-24 Thread Kirti Wankhede
On 3/25/2020 2:15 AM, Alex Williamson wrote: On Tue, 24 Mar 2020 14:37:16 -0600 Alex Williamson wrote: On Wed, 25 Mar 2020 01:02:36 +0530 Kirti Wankhede wrote: VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: - Start dirty pages tracking while migration is active - Stop dirty page

[PATCH v16 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-24 Thread Kirti Wankhede
VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: - Start dirty pages tracking while migration is active - Stop dirty pages tracking. - Get dirty pages bitmap. Its user space application's responsibility to copy content of dirty pages from source to destination during migration. To prevent

Re: [PATCH v16 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-24 Thread Alex Williamson
On Tue, 24 Mar 2020 14:37:16 -0600 Alex Williamson wrote: > On Wed, 25 Mar 2020 01:02:36 +0530 > Kirti Wankhede wrote: > > > VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: > > - Start dirty pages tracking while migration is active > > - Stop dirty pages tracking. > > - Get dirty pages

Re: [PATCH v16 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-24 Thread Alex Williamson
On Wed, 25 Mar 2020 01:02:36 +0530 Kirti Wankhede wrote: > VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: > - Start dirty pages tracking while migration is active > - Stop dirty pages tracking. > - Get dirty pages bitmap. Its user space application's responsibility to > copy content of

[PATCH v16 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-24 Thread Kirti Wankhede
VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: - Start dirty pages tracking while migration is active - Stop dirty pages tracking. - Get dirty pages bitmap. Its user space application's responsibility to copy content of dirty pages from source to destination during migration. To prevent