Re: [PATCH v2] Autoconnect jack ports by default

2021-03-04 Thread Gerd Hoffmann
Hi, > > Well, we need two options then, and have one inconsistent variant. > > Can't we just get along with connect-ports alone, by using the empty > > string for "do not auto connect" ? > > Historically we've been unable to distinguish between the and > scenarios when parsing CLI args. Maybe

Re: [PATCH v2] Autoconnect jack ports by default

2021-03-04 Thread Daniel P . Berrangé
On Thu, Mar 04, 2021 at 02:12:52PM +0100, Gerd Hoffmann wrote: > > I'd suggest a "auto-connect-ports" boolean option, which defaults to > > enabled. > > > > - auto-connect-ports == true, connect-ports= > > > > => use the proposed default regex for connect ports > > > > - auto-connect-por

Re: [PATCH v2] Autoconnect jack ports by default

2021-03-04 Thread Gerd Hoffmann
> I'd suggest a "auto-connect-ports" boolean option, which defaults to > enabled. > > - auto-connect-ports == true, connect-ports= > > => use the proposed default regex for connect ports > > - auto-connect-ports == true, connect-ports = regex > > => use the connect-ports regex > >

Re: [PATCH v2] Autoconnect jack ports by default

2021-03-04 Thread Daniel P . Berrangé
On Thu, Mar 04, 2021 at 12:24:44PM +0100, Christian Schoenebeck wrote: > On Mittwoch, 3. März 2021 08:13:06 CET Gerd Hoffmann wrote: > > Hi, > > > > > JACK clients with consumer purpose often auto connect to system ports by > > > default because their users mostly use JACK just as a consumer des

Re: [PATCH v2] Autoconnect jack ports by default

2021-03-04 Thread Christian Schoenebeck
On Mittwoch, 3. März 2021 08:13:06 CET Gerd Hoffmann wrote: > Hi, > > > JACK clients with consumer purpose often auto connect to system ports by > > default because their users mostly use JACK just as a consumer desktop > > sound server. And I assume this applies to José as well. > > Hmm, ok.

Re: [PATCH v2] Autoconnect jack ports by default

2021-03-02 Thread Gerd Hoffmann
Hi, > JACK clients with consumer purpose often auto connect to system ports by > default because their users mostly use JACK just as a consumer desktop sound > server. And I assume this applies to José as well. Hmm, ok. I'd suggest to simply change the default for connect-ports then, that'll

Re: [PATCH v2] Autoconnect jack ports by default

2021-02-26 Thread Christian Schoenebeck
On Donnerstag, 25. Februar 2021 09:48:55 CET Gerd Hoffmann wrote: > On Wed, Feb 24, 2021 at 11:33:14PM +0100, Christian Schoenebeck wrote: > > On Mittwoch, 24. Februar 2021 23:04:47 CET Geoffrey McRae wrote: > > > This goes against how all standard jack clients work, a new jack client > > > should

Re: [PATCH v2] Autoconnect jack ports by default

2021-02-25 Thread Gerd Hoffmann
On Wed, Feb 24, 2021 at 11:33:14PM +0100, Christian Schoenebeck wrote: > On Mittwoch, 24. Februar 2021 23:04:47 CET Geoffrey McRae wrote: > > This goes against how all standard jack clients work, a new jack client > > should not auto-connect at all unless explicitly configured to as if > > there is

Re: [PATCH v2] Autoconnect jack ports by default

2021-02-25 Thread José Ramón Muñoz Pekkarinen
On Thu, 25 Feb 2021 at 00:38, Geoffrey McRae wrote: > While I get where you're coming from, those using QEMU with Jack are > already advanced users that are used to reading technical documentation. > Having our one client do something that is unexpected/different would > not only confuse existing

Re: [PATCH v2] Autoconnect jack ports by default

2021-02-24 Thread Geoffrey McRae
While I get where you're coming from, those using QEMU with Jack are already advanced users that are used to reading technical documentation. Having our one client do something that is unexpected/different would not only confuse existing Jack users but also anyone following any guides/documenta

Re: [PATCH v2] Autoconnect jack ports by default

2021-02-24 Thread Christian Schoenebeck
On Mittwoch, 24. Februar 2021 23:04:47 CET Geoffrey McRae wrote: > This goes against how all standard jack clients work, a new jack client > should not auto-connect at all unless explicitly configured to as if > there is an existing audio diagram configured (which is 99% of the time) > it will caus

Re: [PATCH v2] Autoconnect jack ports by default

2021-02-24 Thread Geoffrey McRae
This goes against how all standard jack clients work, a new jack client should not auto-connect at all unless explicitly configured to as if there is an existing audio diagram configured (which is 99% of the time) it will cause unexpected/undesired behavior. Jack is not supposed to be an 'auto

Re: [PATCH v2] Autoconnect jack ports by default

2021-02-24 Thread Christian Schoenebeck
On Mittwoch, 24. Februar 2021 20:19:27 CET José Pekkarinen wrote: > This patch provides a default value to connect > jack ports when the user don't specify connect-ports. > > Buglink: https://bugs.launchpad.net/qemu/+bug/1908832 > > Signed-off-by: José Pekkarinen > --- > audio/jackaudio.c | 15

[PATCH v2] Autoconnect jack ports by default

2021-02-24 Thread José Pekkarinen
This patch provides a default value to connect jack ports when the user don't specify connect-ports. Buglink: https://bugs.launchpad.net/qemu/+bug/1908832 Signed-off-by: José Pekkarinen --- audio/jackaudio.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/au