Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals

2021-03-09 Thread Greg Kurz
On Tue, 9 Mar 2021 20:48:40 +0100 Thomas Huth wrote: > On 09/03/2021 18.41, Wainer dos Santos Moschetta wrote: > > Hi, > > > > Any issue that prevent this of being queued? > > Maybe it's just not clear who should take the patch ... CC:-ing qemu-trivial > and qemu-block now, since I think it co

Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals

2021-03-09 Thread Laurent Vivier
Le 09/03/2021 à 20:48, Thomas Huth a écrit : > On 09/03/2021 18.41, Wainer dos Santos Moschetta wrote: >> Hi, >> >> Any issue that prevent this of being queued? > > Maybe it's just not clear who should take the patch ... CC:-ing qemu-trivial > and qemu-block now, > since I think it could go throu

Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals

2021-03-09 Thread Thomas Huth
On 09/03/2021 18.41, Wainer dos Santos Moschetta wrote: Hi, Any issue that prevent this of being queued? Maybe it's just not clear who should take the patch ... CC:-ing qemu-trivial and qemu-block now, since I think it could go through the trivial or block tree. On 2/4/21 10:59 AM, Philipp

Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals

2021-03-09 Thread Wainer dos Santos Moschetta
Hi, Any issue that prevent this of being queued? Thanks! Wainer On 2/4/21 10:59 AM, Philippe Mathieu-Daudé wrote: On 2/4/21 2:54 PM, Wainer dos Santos Moschetta wrote: The qemu-img.rst, qemu-nbd.rst, virtfs-proxy-helper.rst, qemu-trace-stap.rst, and virtiofsd.rst manuals were moved to docs/t

Re: [RFC] Move tools sources to the tools directory (was Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals)

2021-02-04 Thread John Snow
On 2/4/21 9:22 AM, Wainer dos Santos Moschetta wrote: On 2/4/21 10:59 AM, Philippe Mathieu-Daudé wrote: On 2/4/21 2:54 PM, Wainer dos Santos Moschetta wrote: The qemu-img.rst, qemu-nbd.rst, virtfs-proxy-helper.rst, qemu-trace-stap.rst, and virtiofsd.rst manuals were moved to docs/tools, so thi

Re: [RFC] Move tools sources to the tools directory (was Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals)

2021-02-04 Thread Eric Blake
On 2/4/21 8:22 AM, Wainer dos Santos Moschetta wrote: > Unrelated too, but allow me to ask: > > Should we move the tools (qemu-img, qemu-io, qemu-nbd...etc) to the > tools directory (virtiofsd seems to feel alone there)? No complaint by me for qemu-nbd (I had floated the idea before the meson co

Re: [RFC] Move tools sources to the tools directory (was Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals)

2021-02-04 Thread Paolo Bonzini
On 04/02/21 18:42, Philippe Mathieu-Daudé wrote: On 2/4/21 3:40 PM, Paolo Bonzini wrote: On 04/02/21 15:22, Wainer dos Santos Moschetta wrote: -F: docs/interop/virtfs-proxy-helper.rst +F: docs/tools/virtfs-proxy-helper.rst Unrelated, but Paolo once said helpers are not tools. I think helper

Re: [RFC] Move tools sources to the tools directory (was Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals)

2021-02-04 Thread Philippe Mathieu-Daudé
On 2/4/21 4:06 PM, Daniel P. Berrangé wrote: > On Thu, Feb 04, 2021 at 04:02:01PM +0100, Paolo Bonzini wrote: >> On 04/02/21 15:50, Peter Maydell wrote: >>> On Thu, 4 Feb 2021 at 14:47, Daniel P. Berrangé wrote: The distinction of contrib/ vs tools/ is supposed to be more a reflection on

Re: [RFC] Move tools sources to the tools directory (was Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals)

2021-02-04 Thread Paolo Bonzini
On 04/02/21 18:37, Philippe Mathieu-Daudé wrote: - elf2dmp and rdmacm-mux should be in tools/, probably it's in contrib/ because nobody uses it and there's no tests so it might bitrot. Why keep something nobody uses? Well, not really nobody but no maintainer. Paolo

Re: [RFC] Move tools sources to the tools directory (was Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals)

2021-02-04 Thread Philippe Mathieu-Daudé
On 2/4/21 3:40 PM, Paolo Bonzini wrote: > On 04/02/21 15:22, Wainer dos Santos Moschetta wrote: -F: docs/interop/virtfs-proxy-helper.rst +F: docs/tools/virtfs-proxy-helper.rst >>> >>> Unrelated, but Paolo once said helpers are not tools. > > I think helpers is not a good word.  However,

Re: [RFC] Move tools sources to the tools directory (was Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals)

2021-02-04 Thread Daniel P . Berrangé
On Thu, Feb 04, 2021 at 04:02:01PM +0100, Paolo Bonzini wrote: > On 04/02/21 15:50, Peter Maydell wrote: > > On Thu, 4 Feb 2021 at 14:47, Daniel P. Berrangé wrote: > > > The distinction of contrib/ vs tools/ is supposed to be more a > > > reflection on the quality of the program. > > > > > > cont

Re: [RFC] Move tools sources to the tools directory (was Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals)

2021-02-04 Thread Daniel P . Berrangé
On Thu, Feb 04, 2021 at 02:50:08PM +, Peter Maydell wrote: > On Thu, 4 Feb 2021 at 14:47, Daniel P. Berrangé wrote: > > The distinction of contrib/ vs tools/ is supposed to be more a > > reflection on the quality of the program. > > > > contrib/ should be considered demo-ware, no back compat g

Re: [RFC] Move tools sources to the tools directory (was Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals)

2021-02-04 Thread Paolo Bonzini
On 04/02/21 15:50, Peter Maydell wrote: On Thu, 4 Feb 2021 at 14:47, Daniel P. Berrangé wrote: The distinction of contrib/ vs tools/ is supposed to be more a reflection on the quality of the program. contrib/ should be considered demo-ware, no back compat guaranteed, may or may not work, no te

Re: [RFC] Move tools sources to the tools directory (was Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals)

2021-02-04 Thread Kevin Wolf
Am 04.02.2021 um 15:47 hat Daniel P. Berrangé geschrieben: > On Thu, Feb 04, 2021 at 03:40:06PM +0100, Kevin Wolf wrote: > > Am 04.02.2021 um 15:31 hat Peter Maydell geschrieben: > > > On Thu, 4 Feb 2021 at 14:23, Wainer dos Santos Moschetta > > > wrote: > > > > Unrelated too, but allow me to ask:

Re: [RFC] Move tools sources to the tools directory (was Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals)

2021-02-04 Thread Peter Maydell
On Thu, 4 Feb 2021 at 14:47, Daniel P. Berrangé wrote: > The distinction of contrib/ vs tools/ is supposed to be more a > reflection on the quality of the program. > > contrib/ should be considered demo-ware, no back compat guaranteed, > may or may not work, no testing guaranteed, no man pages. O

Re: [RFC] Move tools sources to the tools directory (was Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals)

2021-02-04 Thread Peter Maydell
On Thu, 4 Feb 2021 at 14:40, Kevin Wolf wrote: > > Am 04.02.2021 um 15:31 hat Peter Maydell geschrieben: > > On Thu, 4 Feb 2021 at 14:23, Wainer dos Santos Moschetta > > wrote: > > > Unrelated too, but allow me to ask: > > > > > > Should we move the tools (qemu-img, qemu-io, qemu-nbd...etc) to th

Re: [RFC] Move tools sources to the tools directory (was Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals)

2021-02-04 Thread Daniel P . Berrangé
On Thu, Feb 04, 2021 at 03:40:06PM +0100, Kevin Wolf wrote: > Am 04.02.2021 um 15:31 hat Peter Maydell geschrieben: > > On Thu, 4 Feb 2021 at 14:23, Wainer dos Santos Moschetta > > wrote: > > > Unrelated too, but allow me to ask: > > > > > > Should we move the tools (qemu-img, qemu-io, qemu-nbd...

Re: [RFC] Move tools sources to the tools directory (was Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals)

2021-02-04 Thread Paolo Bonzini
On 04/02/21 15:22, Wainer dos Santos Moschetta wrote: -F: docs/interop/virtfs-proxy-helper.rst +F: docs/tools/virtfs-proxy-helper.rst Unrelated, but Paolo once said helpers are not tools. I think helpers is not a good word. However, if an executable: - can be started directly by QEMU, or is

Re: [RFC] Move tools sources to the tools directory (was Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals)

2021-02-04 Thread Kevin Wolf
Am 04.02.2021 um 15:31 hat Peter Maydell geschrieben: > On Thu, 4 Feb 2021 at 14:23, Wainer dos Santos Moschetta > wrote: > > Unrelated too, but allow me to ask: > > > > Should we move the tools (qemu-img, qemu-io, qemu-nbd...etc) to the > > tools directory (virtiofsd seems to feel alone there)? >

Re: [RFC] Move tools sources to the tools directory (was Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals)

2021-02-04 Thread Peter Maydell
On Thu, 4 Feb 2021 at 14:23, Wainer dos Santos Moschetta wrote: > Unrelated too, but allow me to ask: > > Should we move the tools (qemu-img, qemu-io, qemu-nbd...etc) to the > tools directory (virtiofsd seems to feel alone there)? I think that would be a good thing, yes (things documented in docs

[RFC] Move tools sources to the tools directory (was Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals)

2021-02-04 Thread Wainer dos Santos Moschetta
On 2/4/21 10:59 AM, Philippe Mathieu-Daudé wrote: On 2/4/21 2:54 PM, Wainer dos Santos Moschetta wrote: The qemu-img.rst, qemu-nbd.rst, virtfs-proxy-helper.rst, qemu-trace-stap.rst, and virtiofsd.rst manuals were moved to docs/tools, so this update MAINTAINERS accordingly. Fixes: a08b4a9fe6c

Re: [PATCH v2] MAINTAINERS: Fix the location of tools manuals

2021-02-04 Thread Philippe Mathieu-Daudé
On 2/4/21 2:54 PM, Wainer dos Santos Moschetta wrote: > The qemu-img.rst, qemu-nbd.rst, virtfs-proxy-helper.rst, qemu-trace-stap.rst, > and virtiofsd.rst manuals were moved to docs/tools, so this update MAINTAINERS > accordingly. > > Fixes: a08b4a9fe6c ("docs: Move tools documentation to tools man

[PATCH v2] MAINTAINERS: Fix the location of tools manuals

2021-02-04 Thread Wainer dos Santos Moschetta
The qemu-img.rst, qemu-nbd.rst, virtfs-proxy-helper.rst, qemu-trace-stap.rst, and virtiofsd.rst manuals were moved to docs/tools, so this update MAINTAINERS accordingly. Fixes: a08b4a9fe6c ("docs: Move tools documentation to tools manual") Signed-off-by: Wainer dos Santos Moschetta --- v1: was "M