Re: [PATCH v2] Properly sign extend BBIT branch offset during calculation

2022-10-23 Thread Christopher Wrogg
I agree. Here is the corrected patch. Signed-off-by: Christopher Wrogg Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1251 --- target/mips/tcg/octeon.decode | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/mips/tcg/octeon.decode b/target/mips/tcg/octeon.decode

Re: [PATCH v2] Properly sign extend BBIT branch offset during calculation

2022-10-13 Thread Richard Henderson
On 10/13/22 15:08, Christopher Wrogg wrote: The Octeon specific BBIT instruction incorrectly computes the branch offset. The 16 bit value is not sign extended. Signed-off-by: Christopher Wrogg mailto:cwr...@umich.edu>> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1251

[PATCH v2] Properly sign extend BBIT branch offset during calculation

2022-10-12 Thread Christopher Wrogg
The Octeon specific BBIT instruction incorrectly computes the branch offset. The 16 bit value is not sign extended. Signed-off-by: Christopher Wrogg Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1251 --- target/mips/tcg/octeon_translate.c | 5 - 1 file changed, 4 insertions(+), 1