Re: [PATCH v2] Warn user if the vga flag is passed but no vga device is created

2022-04-27 Thread Thomas Huth
On 23/04/2022 15.27, Peter Maydell wrote: On Sat, 23 Apr 2022 at 11:00, Gautam Agrawal wrote: I will make changes in hw/ppc/spapr.c . In hw/hppa/machine.c , vga_interface_type is used inside if condition to check for graphics device creation, but I am not able to find any relation with

Re: [PATCH v2] Warn user if the vga flag is passed but no vga device is created

2022-04-23 Thread Peter Maydell
On Sat, 23 Apr 2022 at 11:00, Gautam Agrawal wrote: > > I will make changes in hw/ppc/spapr.c . In hw/hppa/machine.c , > vga_interface_type is used inside if condition to check for graphics > device creation, but I am not able to find any relation with creation > of vga interface. Could you

Re: [PATCH v2] Warn user if the vga flag is passed but no vga device is created

2022-04-23 Thread Gautam Agrawal
I will make changes in hw/ppc/spapr.c . In hw/hppa/machine.c , vga_interface_type is used inside if condition to check for graphics device creation, but I am not able to find any relation with creation of vga interface. Could you kindly provide some pointers about it? thanks, Regards, Gautam

Re: [PATCH v2] Warn user if the vga flag is passed but no vga device is created

2022-04-21 Thread Peter Maydell
On Wed, 13 Apr 2022 at 18:23, Gautam Agrawal wrote: > > A global boolean variable "vga_interface_created"(declared in > softmmu/globals.c) > has been used to track the creation of vga interface. If the vga flag is > passed > in the command line "default_vga"(declared in softmmu/vl.c) variable

[PATCH v2] Warn user if the vga flag is passed but no vga device is created

2022-04-13 Thread Gautam Agrawal
A global boolean variable "vga_interface_created"(declared in softmmu/globals.c) has been used to track the creation of vga interface. If the vga flag is passed in the command line "default_vga"(declared in softmmu/vl.c) variable is set to 0. To warn user, the condition checks if