Re: [PATCH v2] block/snapshot: Fix compiler warning with -Wshadow=local

2023-11-06 Thread Cédric Le Goater
On 10/24/23 13:51, Thomas Huth wrote: On 24/10/2023 12.37, Markus Armbruster wrote: Markus Armbruster writes: Thomas Huth writes: No need to declare a new variable in the the inner code block here, we can re-use the "ret" variable that has been declared at the beginning of the function. Wi

Re: [PATCH v2] block/snapshot: Fix compiler warning with -Wshadow=local

2023-10-24 Thread Thomas Huth
On 24/10/2023 12.37, Markus Armbruster wrote: Markus Armbruster writes: Thomas Huth writes: No need to declare a new variable in the the inner code block here, we can re-use the "ret" variable that has been declared at the beginning of the function. With this change, the code can now be suc

Re: [PATCH v2] block/snapshot: Fix compiler warning with -Wshadow=local

2023-10-24 Thread Markus Armbruster
Markus Armbruster writes: > Thomas Huth writes: > >> No need to declare a new variable in the the inner code block >> here, we can re-use the "ret" variable that has been declared >> at the beginning of the function. With this change, the code >> can now be successfully compiled with -Wshadow=lo

Re: [PATCH v2] block/snapshot: Fix compiler warning with -Wshadow=local

2023-10-23 Thread Markus Armbruster
Thomas Huth writes: > No need to declare a new variable in the the inner code block > here, we can re-use the "ret" variable that has been declared > at the beginning of the function. With this change, the code > can now be successfully compiled with -Wshadow=local again. > > Fixes: a32e781838 ("

[PATCH v2] block/snapshot: Fix compiler warning with -Wshadow=local

2023-10-23 Thread Thomas Huth
No need to declare a new variable in the the inner code block here, we can re-use the "ret" variable that has been declared at the beginning of the function. With this change, the code can now be successfully compiled with -Wshadow=local again. Fixes: a32e781838 ("Mark bdrv_snapshot_fallback() and