Re: [PATCH v2] block: Raise an error when backing file parameter is an empty string

2020-08-13 Thread Connor Kuehl
On 8/12/20 1:58 AM, Kevin Wolf wrote: This looks like a test case that would be better served by not using QMPTestCase, but just printing the qemu-img output and having the message compared against the reference output. In fact, there is already 049 for testing some qemu-img create options and w

Re: [PATCH v2] block: Raise an error when backing file parameter is an empty string

2020-08-11 Thread Kevin Wolf
Am 11.08.2020 um 23:23 hat Connor Kuehl geschrieben: > Providing an empty string for the backing file parameter like so: > > qemu-img create -f qcow2 -b '' /tmp/foo > > allows the flow of control to reach and subsequently fail an assert > statement because passing an empty string to > >

[PATCH v2] block: Raise an error when backing file parameter is an empty string

2020-08-11 Thread Connor Kuehl
Providing an empty string for the backing file parameter like so: qemu-img create -f qcow2 -b '' /tmp/foo allows the flow of control to reach and subsequently fail an assert statement because passing an empty string to bdrv_get_full_backing_filename_from_filename() simply result