Re: [PATCH v2] chardev/char-socket: Properly make qio connections non blocking

2020-04-25 Thread Paolo Bonzini
On 20/04/20 11:26, Daniel P. Berrangé wrote: > On Sun, Apr 19, 2020 at 03:21:40PM +0530, Sai Pavan Boddu wrote: >> In tcp_chr_sync_read function, there is a possibility of socket >> disconnection during blocking read, then tcp_chr_hup function would clean up >> the qio channel pointers(i.e ioc, sio

Re: [PATCH v2] chardev/char-socket: Properly make qio connections non blocking

2020-04-20 Thread Daniel P . Berrangé
On Sun, Apr 19, 2020 at 03:21:40PM +0530, Sai Pavan Boddu wrote: > In tcp_chr_sync_read function, there is a possibility of socket > disconnection during blocking read, then tcp_chr_hup function would clean up > the qio channel pointers(i.e ioc, sioc). > > Signed-off-by: Sai Pavan Boddu > --- > C

[PATCH v2] chardev/char-socket: Properly make qio connections non blocking

2020-04-19 Thread Sai Pavan Boddu
In tcp_chr_sync_read function, there is a possibility of socket disconnection during blocking read, then tcp_chr_hup function would clean up the qio channel pointers(i.e ioc, sioc). Signed-off-by: Sai Pavan Boddu --- Changes for V2: Place the guard around 'qio_channel_set_blocking' call t

[QEMU][PATCH v2] chardev/char-socket: Properly make qio connections non blocking

2020-04-19 Thread Sai Pavan Boddu
In tcp_chr_sync_read function, there is a possibility of socket disconnection during read, then tcp_chr_hup function would clean up the qio channel pointers(i.e ioc, sioc). Signed-off-by: Sai Pavan Boddu --- Changes for V2: Simply guard the 'qio_channel_set_blocking' call to check connec