Re: [PATCH v2] contrib/vhost-user-blk: Replace lseek64 with lseek

2022-12-18 Thread Raphael Norwitz
> On Dec 19, 2022, at 12:07 AM, Khem Raj wrote: > > 64bit off_t is already in use since build uses _FILE_OFFSET_BITS=64 > already. Using lseek/off_t also makes it work with latest musl without > using _LARGEFILE64_SOURCE macro. This macro is implied with _GNU_SOURCE > when using glibc but not

Re: [PATCH v2] contrib/vhost-user-blk: Replace lseek64 with lseek

2022-12-18 Thread Philippe Mathieu-Daudé
On 18/12/22 23:07, Khem Raj wrote: 64bit off_t is already in use since build uses _FILE_OFFSET_BITS=64 already. Using lseek/off_t also makes it work with latest musl without using _LARGEFILE64_SOURCE macro. This macro is implied with _GNU_SOURCE when using glibc but not with musl.

[PATCH v2] contrib/vhost-user-blk: Replace lseek64 with lseek

2022-12-18 Thread Khem Raj
64bit off_t is already in use since build uses _FILE_OFFSET_BITS=64 already. Using lseek/off_t also makes it work with latest musl without using _LARGEFILE64_SOURCE macro. This macro is implied with _GNU_SOURCE when using glibc but not with musl. Signed-off-by: Khem Raj Cc: Michael S. Tsirkin