Re: [PATCH v2] hw/i386: fix microvm segfault with virtio cmdline

2023-02-25 Thread Michael S. Tsirkin
On Sat, Feb 25, 2023 at 04:27:57PM -0800, Daniel Hoffman wrote: > The 'microvm' machine type allows for disabling ACPI, in which case > the VirtIO device configuration is passed via appending it to the > kernel cmdline. > > If no cmdline parameter was passed, then a null pointer is dereferenced wh

[PATCH v2] hw/i386: fix microvm segfault with virtio cmdline

2023-02-25 Thread Daniel Hoffman
The 'microvm' machine type allows for disabling ACPI, in which case the VirtIO device configuration is passed via appending it to the kernel cmdline. If no cmdline parameter was passed, then a null pointer is dereferenced when the new cmdline is copied back. A solution is to always define the cmdl