Re: [PATCH v2] hw/net/can: fix Xilinx ZynqMP CAN RX FIFO logic

On Wed, 17 Aug 2022 at 15:33, Peter Maydell wrote: > > On Wed, 17 Aug 2022 at 15:24, Anton Kochkov wrote: > > > > For consistency, function "update_rx_fifo()" should use > > the RX FIFO register names, not the TX FIFO ones even if > > "register field names" > > > they refer to the same memory reg

Re: [PATCH v2] hw/net/can: fix Xilinx ZynqMP CAN RX FIFO logic

On Wed, 17 Aug 2022 at 15:33, Peter Maydell wrote: > > On Wed, 17 Aug 2022 at 15:24, Anton Kochkov wrote: > > > > For consistency, function "update_rx_fifo()" should use > > the RX FIFO register names, not the TX FIFO ones even if > > "register field names" > > > they refer to the same memory reg

Re: [PATCH v2] hw/net/can: fix Xilinx ZynqMP CAN RX FIFO logic

On Wed, 17 Aug 2022 at 15:24, Anton Kochkov wrote: > > For consistency, function "update_rx_fifo()" should use > the RX FIFO register names, not the TX FIFO ones even if "register field names" > they refer to the same memory region. "same bit positions in the register". (No need to spin a v3 j

[PATCH v2] hw/net/can: fix Xilinx ZynqMP CAN RX FIFO logic

For consistency, function "update_rx_fifo()" should use the RX FIFO register names, not the TX FIFO ones even if they refer to the same memory region. Signed-off-by: Anton Kochkov Reviewed-by: Francisco Iglesias Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1123 --- hw/net/can/xlnx-zy