Re: [PATCH v2] lockable: Replace locks with lock guard macros

2020-04-24 Thread Stefan Hajnoczi
On Thu, Apr 02, 2020 at 12:20:35PM +0530, Simran Singhal wrote: > Replace manual lock()/unlock() calls with lock guard macros > (QEMU_LOCK_GUARD/WITH_QEMU_LOCK_GUARD). > > Signed-off-by: Simran Singhal > --- > Changes in v2: > -Drop changes in file hw/rdma/rdma_utils.c > >

Re: [PATCH v2] lockable: Replace locks with lock guard macros

2020-04-20 Thread Philippe Mathieu-Daudé
On 4/2/20 8:50 AM, Simran Singhal wrote: Replace manual lock()/unlock() calls with lock guard macros (QEMU_LOCK_GUARD/WITH_QEMU_LOCK_GUARD). Signed-off-by: Simran Singhal --- You can give a hint to reviewers by adding: This patch is based on: "Replace locks with lock guard macros"

Re: [PATCH v2] lockable: Replace locks with lock guard macros

2020-04-19 Thread Marcel Apfelbaum
Hi Julia, On 4/19/20 5:46 AM, Julia Suvorova wrote: On Sat, Apr 18, 2020 at 2:03 PM Marcel Apfelbaum wrote: Hi Simran, On 4/2/20 9:50 AM, Simran Singhal wrote: Replace manual lock()/unlock() calls with lock guard macros (QEMU_LOCK_GUARD/WITH_QEMU_LOCK_GUARD). Signed-off-by: Simran Singhal

Re: [PATCH v2] lockable: Replace locks with lock guard macros

2020-04-18 Thread Julia Suvorova
On Sat, Apr 18, 2020 at 2:03 PM Marcel Apfelbaum wrote: > > Hi Simran, > > On 4/2/20 9:50 AM, Simran Singhal wrote: > > Replace manual lock()/unlock() calls with lock guard macros > > (QEMU_LOCK_GUARD/WITH_QEMU_LOCK_GUARD). > > > > Signed-off-by: Simran Singhal > > --- > > Changes in v2: > >

Re: [PATCH v2] lockable: Replace locks with lock guard macros

2020-04-18 Thread Marcel Apfelbaum
Hi Simran, On 4/2/20 9:50 AM, Simran Singhal wrote: Replace manual lock()/unlock() calls with lock guard macros (QEMU_LOCK_GUARD/WITH_QEMU_LOCK_GUARD). Signed-off-by: Simran Singhal --- Changes in v2: -Drop changes in file hw/rdma/rdma_utils.c hw/hyperv/hyperv.c | 15

Re: [PATCH v2] lockable: Replace locks with lock guard macros

2020-04-14 Thread Marcel Apfelbaum
Hi Simran, On 4/2/20 9:50 AM, Simran Singhal wrote: Replace manual lock()/unlock() calls with lock guard macros (QEMU_LOCK_GUARD/WITH_QEMU_LOCK_GUARD). Signed-off-by: Simran Singhal --- Changes in v2: -Drop changes in file hw/rdma/rdma_utils.c hw/hyperv/hyperv.c | 15

Re: [PATCH v2] lockable: Replace locks with lock guard macros

2020-04-13 Thread Yuval Shaia
On Thu, 2 Apr 2020 at 09:50, Simran Singhal wrote: > Replace manual lock()/unlock() calls with lock guard macros > (QEMU_LOCK_GUARD/WITH_QEMU_LOCK_GUARD). > > Signed-off-by: Simran Singhal > --- > Changes in v2: > -Drop changes in file hw/rdma/rdma_utils.c > So i guess we are expected

Re: [PATCH v2] lockable: Replace locks with lock guard macros

2020-04-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200402065035.GA15477@simran-Inspiron-5558/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash

[PATCH v2] lockable: Replace locks with lock guard macros

2020-04-02 Thread Simran Singhal
Replace manual lock()/unlock() calls with lock guard macros (QEMU_LOCK_GUARD/WITH_QEMU_LOCK_GUARD). Signed-off-by: Simran Singhal --- Changes in v2: -Drop changes in file hw/rdma/rdma_utils.c hw/hyperv/hyperv.c | 15 ++--- hw/rdma/rdma_backend.c | 50