Re: [PATCH v2] migration: Handle block device inactivation failures better

2023-05-02 Thread Eric Blake
On Tue, May 02, 2023 at 11:54:12AM +0200, Kevin Wolf wrote: > Hi Eric, > > you asked me for a review downstream, but since you would have to bring > back any problem to upstream anyway, let's discuss it here. For the > start, let me state that (a) I don't fully understand why this patch > fixes

Re: [PATCH v2] migration: Handle block device inactivation failures better

2023-05-02 Thread Kevin Wolf
Hi Eric, you asked me for a review downstream, but since you would have to bring back any problem to upstream anyway, let's discuss it here. For the start, let me state that (a) I don't fully understand why this patch fixes things and (b) I hate this function. More below. Am 14.04.2023 um 17:33

Re: [PATCH v2] migration: Handle block device inactivation failures better

2023-04-20 Thread Eric Blake
On Thu, Apr 20, 2023 at 12:41:25PM +0200, Juan Quintela wrote: > Eric Blake wrote: ...lots of lines... > > --- > > migration/migration.c | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) ...describing a tiny change ;) > > > > diff --git a/migration/migration.c

Re: [PATCH v2] migration: Handle block device inactivation failures better

2023-04-20 Thread Juan Quintela
Eric Blake wrote: > Consider what happens when performing a migration between two host > machines connected to an NFS server serving multiple block devices to > the guest, when the NFS server becomes unavailable. The migration > attempts to inactivate all block devices on the source (a necessary

Re: [PATCH v2] migration: Handle block device inactivation failures better

2023-04-20 Thread Lukas Straub
On Fri, 14 Apr 2023 10:33:58 -0500 Eric Blake wrote: > Consider what happens when performing a migration between two host > machines connected to an NFS server serving multiple block devices to > the guest, when the NFS server becomes unavailable. The migration > attempts to inactivate all

[PATCH v2] migration: Handle block device inactivation failures better

2023-04-14 Thread Eric Blake
Consider what happens when performing a migration between two host machines connected to an NFS server serving multiple block devices to the guest, when the NFS server becomes unavailable. The migration attempts to inactivate all block devices on the source (a necessary step before the