Re: [PATCH v2] migration: check magic value for deciding the mapping of channels

2022-11-16 Thread manish.mishra
On 16/11/22 4:57 pm, Daniel P. Berrangé wrote: On Wed, Nov 16, 2022 at 04:49:18PM +0530, manish.mishra wrote: On 16/11/22 12:20 am, Daniel P. Berrangé wrote: On Tue, Nov 15, 2022 at 06:11:30PM +, Daniel P. Berrangé wrote: On Mon, Nov 07, 2022 at 04:51:59PM +, manish.mishra wrote:

Re: [PATCH v2] migration: check magic value for deciding the mapping of channels

2022-11-16 Thread Daniel P . Berrangé
On Wed, Nov 16, 2022 at 04:49:18PM +0530, manish.mishra wrote: > > On 16/11/22 12:20 am, Daniel P. Berrangé wrote: > > On Tue, Nov 15, 2022 at 06:11:30PM +, Daniel P. Berrangé wrote: > > > On Mon, Nov 07, 2022 at 04:51:59PM +, manish.mishra wrote: > > > > Current logic assumes that

Re: [PATCH v2] migration: check magic value for deciding the mapping of channels

2022-11-16 Thread manish.mishra
On 16/11/22 12:20 am, Daniel P. Berrangé wrote: On Tue, Nov 15, 2022 at 06:11:30PM +, Daniel P. Berrangé wrote: On Mon, Nov 07, 2022 at 04:51:59PM +, manish.mishra wrote: Current logic assumes that channel connections on the destination side are always established in the same order as

Re: [PATCH v2] migration: check magic value for deciding the mapping of channels

2022-11-15 Thread Peter Xu
On Tue, Nov 15, 2022 at 11:29:13PM +0530, manish.mishra wrote: > > > + while (bytes < nbytes) { > > > + bytes = klass->io_read_peek(ioc, > > > + buf, > > > + nbytes, > > > + errp); > >

Re: [PATCH v2] migration: check magic value for deciding the mapping of channels

2022-11-15 Thread Daniel P . Berrangé
On Tue, Nov 15, 2022 at 06:11:30PM +, Daniel P. Berrangé wrote: > On Mon, Nov 07, 2022 at 04:51:59PM +, manish.mishra wrote: > > Current logic assumes that channel connections on the destination side are > > always established in the same order as the source and the first one will > >

Re: [PATCH v2] migration: check magic value for deciding the mapping of channels

2022-11-15 Thread Daniel P . Berrangé
On Mon, Nov 07, 2022 at 04:51:59PM +, manish.mishra wrote: > Current logic assumes that channel connections on the destination side are > always established in the same order as the source and the first one will > always be the main channel followed by the multifid or post-copy > preemption

Re: [PATCH v2] migration: check magic value for deciding the mapping of channels

2022-11-15 Thread manish.mishra
On 15/11/22 11:06 pm, Peter Xu wrote: Hi, Manish, On Mon, Nov 07, 2022 at 04:51:59PM +, manish.mishra wrote: Current logic assumes that channel connections on the destination side are always established in the same order as the source and the first one will always be the main channel

Re: [PATCH v2] migration: check magic value for deciding the mapping of channels

2022-11-15 Thread Peter Xu
Hi, Manish, On Mon, Nov 07, 2022 at 04:51:59PM +, manish.mishra wrote: > Current logic assumes that channel connections on the destination side are > always established in the same order as the source and the first one will > always be the main channel followed by the multifid or post-copy >

Re: [PATCH v2] migration: check magic value for deciding the mapping of channels

2022-11-10 Thread manish.mishra
On 11/11/22 4:17 am, Peter Xu wrote: On Thu, Nov 10, 2022 at 05:59:45PM +0530, manish.mishra wrote: Hi Everyone, Just a gentle reminder for review. :) Hi, Manish, I've got a slightly busy week, sorry! If Daniel and Juan won't have time to look at it I'll have a closer look at it next

Re: [PATCH v2] migration: check magic value for deciding the mapping of channels

2022-11-10 Thread Peter Xu
On Thu, Nov 10, 2022 at 05:59:45PM +0530, manish.mishra wrote: > Hi Everyone, Just a gentle reminder for review. :) Hi, Manish, I've got a slightly busy week, sorry! If Daniel and Juan won't have time to look at it I'll have a closer look at it next Monday (holiday tomorrow). -- Peter Xu

Re: [PATCH v2] migration: check magic value for deciding the mapping of channels

2022-11-10 Thread manish.mishra
Hi Everyone, Just a gentle reminder for review. :) Thanks Manish Mishra On 07/11/22 10:21 pm, manish.mishra wrote: Current logic assumes that channel connections on the destination side are always established in the same order as the source and the first one will always be the main channel

Re: [PATCH v2] migration: check magic value for deciding the mapping of channels

2022-11-08 Thread manish.mishra
On 07/11/22 10:21 pm, manish.mishra wrote: Current logic assumes that channel connections on the destination side are always established in the same order as the source and the first one will always be the main channel followed by the multifid or post-copy preemption channel. This may not be

[PATCH v2] migration: check magic value for deciding the mapping of channels

2022-11-07 Thread manish.mishra
Current logic assumes that channel connections on the destination side are always established in the same order as the source and the first one will always be the main channel followed by the multifid or post-copy preemption channel. This may not be always true, as even if a channel has a