Re: [PATCH v2] net: add tulip (dec21143) driver

2019-10-27 Thread Jason Wang
On 2019/10/25 下午7:43, Michael S. Tsirkin wrote: On Tue, Oct 22, 2019 at 05:54:13PM +0200, Sven Schnelle wrote: This adds the basic functionality to emulate a Tulip NIC. Jason, do you want to queue this? Overall ok so Acked-by: Michael S. Tsirkin Yes, I've queued V3 of this. Thanks

Re: [PATCH v2] net: add tulip (dec21143) driver

2019-10-25 Thread Michael S. Tsirkin
On Tue, Oct 22, 2019 at 05:54:13PM +0200, Sven Schnelle wrote: > This adds the basic functionality to emulate a Tulip NIC. Jason, do you want to queue this? Overall ok so Acked-by: Michael S. Tsirkin > Implemented are: > > - RX and TX functionality > - Perfect Frame Filtering > - Big/Little

Re: [PATCH v2] net: add tulip (dec21143) driver

2019-10-23 Thread Sven Schnelle
On Tue, Oct 22, 2019 at 05:00:16PM +0100, Peter Maydell wrote: > > There are a couple of minor wrong-indent nits: > > > +static void tulip_update_ts(TULIPState *s, int state) > > +{ > > +s->csr[5] &= ~(CSR5_TS_MASK << CSR5_TS_SHIFT); > > +s->csr[5] |= (state & CSR5_TS_MASK) << CSR

Re: [PATCH v2] net: add tulip (dec21143) driver

2019-10-23 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191022155413.4619-1-sv...@stackframe.org/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

[PATCH v2] net: add tulip (dec21143) driver

2019-10-22 Thread Sven Schnelle
This adds the basic functionality to emulate a Tulip NIC. Implemented are: - RX and TX functionality - Perfect Frame Filtering - Big/Little Endian descriptor support - 93C46 EEPROM support - LXT970 PHY Not implemented, mostly because i had no OS using these functions: - Imperfect frame filterin

Re: [PATCH v2] net: add tulip (dec21143) driver

2019-10-22 Thread Peter Maydell
On Tue, 22 Oct 2019 at 16:54, Sven Schnelle wrote: > > This adds the basic functionality to emulate a Tulip NIC. > > Implemented are: > > - RX and TX functionality > - Perfect Frame Filtering > - Big/Little Endian descriptor support > - 93C46 EEPROM support > - LXT970 PHY > > Not implemented, most