Re: [PATCH v2] pci: Assert that capabilities never overlap

2022-10-13 Thread Michael S. Tsirkin
On Thu, Oct 13, 2022 at 02:39:27PM +0900, Akihiko Odaki wrote: > Yes, I'd like to hear your ideas on how it should be split up. The > main challenge here is that it changes the signature of a function > without changing its name. Lots of ways to do it, e.g.: 1. add a new api with a new name 2.

Re: [PATCH v2] pci: Assert that capabilities never overlap

2022-10-12 Thread Akihiko Odaki
On Thu, Sep 29, 2022 at 7:55 PM Markus Armbruster wrote: > > Akihiko Odaki writes: > > > On Mon, Sep 5, 2022 at 6:26 PM Markus Armbruster wrote: > >> > >> Akihiko Odaki writes: > >> > >> > On Fri, Sep 2, 2022 at 7:23 PM Markus Armbruster > >> > wrote: > >> >> > >> >> Akihiko Odaki writes: >

Re: [PATCH v2] pci: Assert that capabilities never overlap

2022-09-29 Thread Markus Armbruster
Akihiko Odaki writes: > On Mon, Sep 5, 2022 at 6:26 PM Markus Armbruster wrote: >> >> Akihiko Odaki writes: >> >> > On Fri, Sep 2, 2022 at 7:23 PM Markus Armbruster wrote: >> >> >> >> Akihiko Odaki writes: >> >> >> >> > pci_add_capability appears most PCI devices. Its error handling required

Re: [PATCH v2] pci: Assert that capabilities never overlap

2022-09-29 Thread Akihiko Odaki
On Mon, Sep 5, 2022 at 7:11 PM Akihiko Odaki wrote: > > On Mon, Sep 5, 2022 at 6:26 PM Markus Armbruster wrote: > > > > Akihiko Odaki writes: > > > > > On Fri, Sep 2, 2022 at 7:23 PM Markus Armbruster > > > wrote: > > >> > > >> Akihiko Odaki writes: > > >> > > >> > pci_add_capability appears

Re: [PATCH v2] pci: Assert that capabilities never overlap

2022-09-05 Thread Akihiko Odaki
On Mon, Sep 5, 2022 at 6:26 PM Markus Armbruster wrote: > > Akihiko Odaki writes: > > > On Fri, Sep 2, 2022 at 7:23 PM Markus Armbruster wrote: > >> > >> Akihiko Odaki writes: > >> > >> > pci_add_capability appears most PCI devices. Its error handling required > >> > lots of code, and led to

Re: [PATCH v2] pci: Assert that capabilities never overlap

2022-09-05 Thread Markus Armbruster
Akihiko Odaki writes: > On Fri, Sep 2, 2022 at 7:23 PM Markus Armbruster wrote: >> >> Akihiko Odaki writes: >> >> > pci_add_capability appears most PCI devices. Its error handling required >> > lots of code, and led to inconsistent behaviors such as: >> > - passing error_abort >> > - passing

Re: [PATCH v2] pci: Assert that capabilities never overlap

2022-09-04 Thread Akihiko Odaki
On Fri, Sep 2, 2022 at 7:23 PM Markus Armbruster wrote: > > Akihiko Odaki writes: > > > pci_add_capability appears most PCI devices. Its error handling required > > lots of code, and led to inconsistent behaviors such as: > > - passing error_abort > > - passing error_fatal > > - asserting the

Re: [PATCH v2] pci: Assert that capabilities never overlap

2022-09-02 Thread Markus Armbruster
Akihiko Odaki writes: > pci_add_capability appears most PCI devices. Its error handling required > lots of code, and led to inconsistent behaviors such as: > - passing error_abort > - passing error_fatal > - asserting the returned value > - propagating the error to the caller > - skipping the

[PATCH v2] pci: Assert that capabilities never overlap

2022-08-30 Thread Akihiko Odaki
pci_add_capability appears most PCI devices. Its error handling required lots of code, and led to inconsistent behaviors such as: - passing error_abort - passing error_fatal - asserting the returned value - propagating the error to the caller - skipping the rest of the function - just ignoring