Re: [PATCH v2] pflash: Only read non-zero parts of backend image

2023-01-10 Thread Kevin Wolf
Am 20.12.2022 um 09:42 hat Gerd Hoffmann geschrieben: > From: Xiang Zheng > > Currently we fill the VIRT_FLASH memory space with two 64MB NOR images > when using persistent UEFI variables on virt board. Actually we only use > a very small(non-zero) part of the memory while the rest significant >

Re: [PATCH v2] pflash: Only read non-zero parts of backend image

2023-01-02 Thread Gerd Hoffmann
Hi, > > Moving away from pflash for efi variable storage would cause alot of > > churn through the whole stack. firmware, qemu, libvirt, upper > > management, all affected. Is that worth the trouble? Using pflash > > isn't that much of a problem IMHO. > > Agreed. pflash is a bit clunky but

Re: [PATCH v2] pflash: Only read non-zero parts of backend image

2022-12-23 Thread Ard Biesheuvel
On Tue, 20 Dec 2022 at 16:33, Gerd Hoffmann wrote: > > On Tue, Dec 20, 2022 at 10:30:43AM +0100, Philippe Mathieu-Daudé wrote: > > [Extending to people using UEFI VARStore on Virt machines] > > > > On 20/12/22 09:42, Gerd Hoffmann wrote: > > > From: Xiang Zheng > > > > > > Currently we fill the

Re: [PATCH v2] pflash: Only read non-zero parts of backend image

2022-12-20 Thread Gerd Hoffmann
On Tue, Dec 20, 2022 at 10:30:43AM +0100, Philippe Mathieu-Daudé wrote: > [Extending to people using UEFI VARStore on Virt machines] > > On 20/12/22 09:42, Gerd Hoffmann wrote: > > From: Xiang Zheng > > > > Currently we fill the VIRT_FLASH memory space with two 64MB NOR images > > when using

Re: [PATCH v2] pflash: Only read non-zero parts of backend image

2022-12-20 Thread Daniel P . Berrangé
On Tue, Dec 20, 2022 at 09:42:46AM +0100, Gerd Hoffmann wrote: > From: Xiang Zheng > > Currently we fill the VIRT_FLASH memory space with two 64MB NOR images > when using persistent UEFI variables on virt board. Actually we only use > a very small(non-zero) part of the memory while the rest

Re: [PATCH v2] pflash: Only read non-zero parts of backend image

2022-12-20 Thread Philippe Mathieu-Daudé
[Extending to people using UEFI VARStore on Virt machines] On 20/12/22 09:42, Gerd Hoffmann wrote: From: Xiang Zheng Currently we fill the VIRT_FLASH memory space with two 64MB NOR images when using persistent UEFI variables on virt board. Actually we only use a very small(non-zero) part of

[PATCH v2] pflash: Only read non-zero parts of backend image

2022-12-20 Thread Gerd Hoffmann
From: Xiang Zheng Currently we fill the VIRT_FLASH memory space with two 64MB NOR images when using persistent UEFI variables on virt board. Actually we only use a very small(non-zero) part of the memory while the rest significant large(zero) part of memory is wasted. So this patch checks the