Re: [PATCH v2] scsi-disk: support setting CD-ROM block size via device options

2022-09-30 Thread Paolo Bonzini
Queued, thanks. Sorry for the delay. Paolo

Re: [PATCH v2] scsi-disk: support setting CD-ROM block size via device options

2022-09-25 Thread John Millikin
Gentle ping again. I'd really like to get this ~6 line patch into mainline so I can pop it off my TODO list. On Mon, Sep 12, 2022 at 04:54:52PM +0900, John Millikin wrote: > Gentle ping -- is there anything blocking this patch from going in? > > It's been about a month now since I sent it, and

Re: [PATCH v2] scsi-disk: support setting CD-ROM block size via device options

2022-09-12 Thread John Millikin
Gentle ping -- is there anything blocking this patch from going in? It's been about a month now since I sent it, and it's not very big, so I was hoping it would merge without much difficulty. If it's breaking a test or something then I'd be happy to take a look and send a new revision. On Mon,

Re: [PATCH v2] scsi-disk: support setting CD-ROM block size via device options

2022-09-05 Thread Paolo Bonzini
Probably just my screw up, or it broke something when testing... let me check. Paolo Il lun 5 set 2022, 05:30 John Millikin ha scritto: > I notice this patch wasn't included in the [PULL] series last week, and > it isn't present in the `master` branch. > > Is there anything else I should be

Re: [PATCH v2] scsi-disk: support setting CD-ROM block size via device options

2022-09-04 Thread John Millikin
I notice this patch wasn't included in the [PULL] series last week, and it isn't present in the `master` branch. Is there anything else I should be doing to get it merged in? Sorry if this isn't a good question, I'm not used to QEMU's email-based change management workflow. On Sat, Aug 20, 2022

Re: [PATCH v2] scsi-disk: support setting CD-ROM block size via device options

2022-08-20 Thread Paolo Bonzini
No, I had not seen it indeed. Queued now, thanks. Paolo Il gio 4 ago 2022, 14:39 John Millikin ha scritto: > SunOS expects CD-ROM devices to have a block size of 512, and will > fail to mount or install using QEMU's default block size of 2048. > > When initializing the SCSI device, allow the

Re: [PATCH v2] scsi-disk: support setting CD-ROM block size via device options

2022-08-19 Thread John Millikin
Gentle ping On Thu, Aug 04, 2022 at 09:29:51PM +0900, John Millikin wrote: > SunOS expects CD-ROM devices to have a block size of 512, and will > fail to mount or install using QEMU's default block size of 2048. > > When initializing the SCSI device, allow the `physical_block_size' > block

[PATCH v2] scsi-disk: support setting CD-ROM block size via device options

2022-08-04 Thread John Millikin
SunOS expects CD-ROM devices to have a block size of 512, and will fail to mount or install using QEMU's default block size of 2048. When initializing the SCSI device, allow the `physical_block_size' block device option to override the default block size. Signed-off-by: John Millikin ---