Re: [PATCH v2] target/arm: Fix 32-bit SMOPA

2024-03-13 Thread Richard Henderson
On 3/13/24 09:12, Michael Tokarev wrote: warning: TCG temporary leaks before 00400730 qemu-aarch64: ../tcg/tcg.c:1052: tcg_temp_free_internal: Assertion `ts->temp_allocated != 0' failed. timeout: the monitored command dumped core Trace/breakpoint trap Does it make sense to pick this fo

Re: [PATCH v2] target/arm: Fix 32-bit SMOPA

2024-03-13 Thread Michael Tokarev
10.03.2024 21:13, Richard Henderson wrote: On 3/9/24 08:40, Michael Tokarev wrote: ... I tried to pick this one up for stable-7.2 (since the fix is for older commit), and faced a fun issue in this change to tests/tcg/aarch64/Makefile.target, since 7.2. doesn't have CROSS_AS_HAS_ARMV9_SME yet. 

Re: [PATCH v2] target/arm: Fix 32-bit SMOPA

2024-03-10 Thread Michael Tokarev
10.03.2024 21:13, Richard Henderson : ... If it all applies without drama, all is well. This very fix applies and works just fine on top of 7.2, it is only the tests part (the Makefile.target fragment) which isn't, so it's kinda problematic to apply it without a test. And while figuring out wh

Re: [PATCH v2] target/arm: Fix 32-bit SMOPA

2024-03-10 Thread Richard Henderson
On 3/9/24 08:40, Michael Tokarev wrote: 05.03.2024 19:39, Richard Henderson wrote: While the 8-bit input elements are sequential in the input vector, the 32-bit output elements are not sequential in the output matrix. Do not attempt to compute 2 32-bit outputs at the same time. Cc: qemu-sta...@

Re: [PATCH v2] target/arm: Fix 32-bit SMOPA

2024-03-09 Thread Michael Tokarev
05.03.2024 19:39, Richard Henderson wrote: While the 8-bit input elements are sequential in the input vector, the 32-bit output elements are not sequential in the output matrix. Do not attempt to compute 2 32-bit outputs at the same time. Cc: qemu-sta...@nongnu.org Fixes: 23a5e3859f5 ("target/ar

Re: [PATCH v2] target/arm: Fix 32-bit SMOPA

2024-03-07 Thread Peter Maydell
On Tue, 5 Mar 2024 at 16:39, Richard Henderson wrote: > > While the 8-bit input elements are sequential in the input vector, > the 32-bit output elements are not sequential in the output matrix. > Do not attempt to compute 2 32-bit outputs at the same time. > > Cc: qemu-sta...@nongnu.org > Fixes:

Re: [PATCH v2] target/arm: Fix 32-bit SMOPA

2024-03-05 Thread Philippe Mathieu-Daudé
On 5/3/24 17:39, Richard Henderson wrote: While the 8-bit input elements are sequential in the input vector, the 32-bit output elements are not sequential in the output matrix. Do not attempt to compute 2 32-bit outputs at the same time. Cc: qemu-sta...@nongnu.org Fixes: 23a5e3859f5 ("target/arm

[PATCH v2] target/arm: Fix 32-bit SMOPA

2024-03-05 Thread Richard Henderson
While the 8-bit input elements are sequential in the input vector, the 32-bit output elements are not sequential in the output matrix. Do not attempt to compute 2 32-bit outputs at the same time. Cc: qemu-sta...@nongnu.org Fixes: 23a5e3859f5 ("target/arm: Implement SME integer outer product") Reso