Re: [PATCH v2] target/i386: Revert monitor_puts() in do_inject_x86_mce()

2024-03-21 Thread Michael Tokarev
20.03.2024 11:36, Tao Su : monitor_puts() doesn't check the monitor pointer, but do_inject_x86_mce() may have a parameter with NULL monitor pointer. Revert monitor_puts() in do_inject_x86_mce() to fix, then the fact that we send the same message to monitor and log is again more obvious. Fixes: b

Re: [PATCH v2] target/i386: Revert monitor_puts() in do_inject_x86_mce()

2024-03-20 Thread Daniel P . Berrangé
On Wed, Mar 20, 2024 at 03:34:43PM +0100, Markus Armbruster wrote: > Peter Maydell writes: > > > On Wed, 20 Mar 2024 at 13:03, Daniel P. Berrangé > > wrote: > >> > >> On Wed, Mar 20, 2024 at 04:36:40PM +0800, Tao Su wrote: > >> > monitor_puts() doesn't check the monitor pointer, but do_inject_x

Re: [PATCH v2] target/i386: Revert monitor_puts() in do_inject_x86_mce()

2024-03-20 Thread Markus Armbruster
Peter Maydell writes: > On Wed, 20 Mar 2024 at 13:03, Daniel P. Berrangé wrote: >> >> On Wed, Mar 20, 2024 at 04:36:40PM +0800, Tao Su wrote: >> > monitor_puts() doesn't check the monitor pointer, but do_inject_x86_mce() >> > may have a parameter with NULL monitor pointer. Revert monitor_puts()

Re: [PATCH v2] target/i386: Revert monitor_puts() in do_inject_x86_mce()

2024-03-20 Thread Peter Maydell
On Wed, 20 Mar 2024 at 13:03, Daniel P. Berrangé wrote: > > On Wed, Mar 20, 2024 at 04:36:40PM +0800, Tao Su wrote: > > monitor_puts() doesn't check the monitor pointer, but do_inject_x86_mce() > > may have a parameter with NULL monitor pointer. Revert monitor_puts() in > > do_inject_x86_mce() to

Re: [PATCH v2] target/i386: Revert monitor_puts() in do_inject_x86_mce()

2024-03-20 Thread Daniel P . Berrangé
On Wed, Mar 20, 2024 at 04:36:40PM +0800, Tao Su wrote: > monitor_puts() doesn't check the monitor pointer, but do_inject_x86_mce() > may have a parameter with NULL monitor pointer. Revert monitor_puts() in > do_inject_x86_mce() to fix, then the fact that we send the same message to > monitor and l

Re: [PATCH v2] target/i386: Revert monitor_puts() in do_inject_x86_mce()

2024-03-20 Thread Paolo Bonzini
Queued, thanks. Paolo

[PATCH v2] target/i386: Revert monitor_puts() in do_inject_x86_mce()

2024-03-20 Thread Tao Su
monitor_puts() doesn't check the monitor pointer, but do_inject_x86_mce() may have a parameter with NULL monitor pointer. Revert monitor_puts() in do_inject_x86_mce() to fix, then the fact that we send the same message to monitor and log is again more obvious. Fixes: bf0c50d4aa85 (monitor: expose