subject:"\[PATCH v2\] target\/riscv\: Restore the predicate\(\) NULL check behavior"

Re: [PATCH v2] target/riscv: Restore the predicate() NULL check behavior

2023-04-16 Thread Alistair Francis

On Mon, Apr 17, 2023 at 2:32 PM Bin Meng wrote: > > When reading a non-existent CSR QEMU should raise illegal instruction > exception, but currently it just exits due to the g_assert() check. > > This actually reverts commit 0ee342256af9205e7388efdf193a6d8f1ba1a617. > Some comments are also added

[PATCH v2] target/riscv: Restore the predicate() NULL check behavior

2023-04-16 Thread Bin Meng

When reading a non-existent CSR QEMU should raise illegal instruction exception, but currently it just exits due to the g_assert() check. This actually reverts commit 0ee342256af9205e7388efdf193a6d8f1ba1a617. Some comments are also added to indicate that predicate() must be provided for an impleme