On Mon, Sep 22, 2025 at 12:37:57PM +0200, Markus Armbruster wrote:
> Alessandro Ratti writes:
>
> > Replace virtio_error() with a macro that automatically prepends the
> > calling function name to error messages. This provides better context
> > for debugging virtio issues by showing exactly whic
Alessandro Ratti writes:
> On Mon, 22 Sept 2025 at 14:29, Markus Armbruster wrote:
>>
>> Alex Bennée writes:
>>
>> > Daniel P. Berrangé writes:
>> >
>> >> On Mon, Sep 22, 2025 at 12:37:57PM +0200, Markus Armbruster wrote:
>> >>> Alessandro Ratti writes:
>> >>>
>> >>> > Replace virtio_error()
Alex Bennée writes:
> Daniel P. Berrangé writes:
>
>> On Mon, Sep 22, 2025 at 12:37:57PM +0200, Markus Armbruster wrote:
>>> Alessandro Ratti writes:
>>>
>>> > Replace virtio_error() with a macro that automatically prepends the
>>> > calling function name to error messages. This provides bette
> > For completeness you could also fixup:
> >
> > virtio_error(vdev, "%s: %d reason unknown", __func__, pnd->reason);
> >
> > for virtio-ballon. Otherwise:
> >
> > Reviewed-by: Alex Bennée
>
> Thank you for your review.
> I've missed that. For completeness, I've sent out a v2 that removes th
Daniel P. Berrangé writes:
> On Mon, Sep 22, 2025 at 12:37:57PM +0200, Markus Armbruster wrote:
>> Alessandro Ratti writes:
>>
>> > Replace virtio_error() with a macro that automatically prepends the
>> > calling function name to error messages. This provides better context
>> > for debugging v
Alessandro Ratti writes:
> Replace virtio_error() with a macro that automatically prepends the
> calling function name to error messages. This provides better context
> for debugging virtio issues by showing exactly which function
> encountered the error.
>
> Before: "Invalid queue size: 1024"
>
Replace virtio_error() with a macro that automatically prepends the
calling function name to error messages. This provides better context
for debugging virtio issues by showing exactly which function
encountered the error.
Before: "Invalid queue size: 1024"
After: "virtio_queue_set_num: Invalid q
