Re: [PATCH v2 0/2] qga: improve "syslog" domain logging

2022-12-16 Thread Konstantin Kostiuk
Thanks. You are right. I tested another command and don't see logs in the event viewer. PR was sent. On Fri, Dec 16, 2022 at 5:27 PM Andrey Drobyshev < andrey.drobys...@virtuozzo.com> wrote: > On 12/16/22 12:01, Konstantin Kostiuk wrote: > > Reviewed-by: Konstantin Kostiuk >

Re: [PATCH v2 0/2] qga: improve "syslog" domain logging

2022-12-16 Thread Andrey Drobyshev
On 12/16/22 12:01, Konstantin Kostiuk wrote: > Reviewed-by: Konstantin Kostiuk > > Tested-by: Konstantin Kostiuk > > > > Hi Andrey, > Do you expect Event Viewer to be empty by default in the current > implementation? > Currently, all logs

Re: [PATCH v2 0/2] qga: improve "syslog" domain logging

2022-12-16 Thread Konstantin Kostiuk
Reviewed-by: Konstantin Kostiuk Tested-by: Konstantin Kostiuk Hi Andrey, Do you expect Event Viewer to be empty by default in the current implementation? Currently, all logs that we write in the guest agent do not have "syslog" domain so we will have logs only in file. On Mon, Dec 12, 2022 at

Re: [PATCH v2 0/2] qga: improve "syslog" domain logging

2022-12-12 Thread Konstantin Kostiuk
Currently, there is a code freeze in QEMU for release 7.2. I will merge this after it https://wiki.qemu.org/Planning/7.2 Best Regards, Konstantin Kostiuk. On Mon, Dec 12, 2022 at 2:17 PM Andrey Drobyshev < andrey.drobys...@virtuozzo.com> wrote: > On 11/29/22 19:38, Andrey Drobyshev wrote: > > T

Re: [PATCH v2 0/2] qga: improve "syslog" domain logging

2022-12-12 Thread Andrey Drobyshev
On 11/29/22 19:38, Andrey Drobyshev wrote: > These patches extend QGA logging interface, primarily under Windows > guests. They enable QGA to write to Windows event log, much like > syslog() on *nix. In addition we get rid of hardcoded log level used by > ga_log(). > > v2: > * Close event_log ha

[PATCH v2 0/2] qga: improve "syslog" domain logging

2022-11-29 Thread Andrey Drobyshev via
These patches extend QGA logging interface, primarily under Windows guests. They enable QGA to write to Windows event log, much like syslog() on *nix. In addition we get rid of hardcoded log level used by ga_log(). v2: * Close event_log handle when doing cleanup_agent() * Fix switch cases indent