Re: Time to introduce a migration protocol negotiation (Re: [PATCH v2 00/25] migration: Postcopy Preemption)

2022-03-18 Thread Peter Xu
On Wed, Mar 16, 2022 at 11:00:53AM +, Daniel P. Berrangé wrote: > On Wed, Mar 16, 2022 at 06:40:08PM +0800, Peter Xu wrote: > > On Wed, Mar 16, 2022 at 09:59:28AM +, Daniel P. Berrangé wrote: > > > On Wed, Mar 16, 2022 at 11:30:59AM +0800, Peter Xu wrote: > > > > On Tue, Mar 15, 2022 at 11:

Re: Time to introduce a migration protocol negotiation (Re: [PATCH v2 00/25] migration: Postcopy Preemption)

2022-03-16 Thread Daniel P . Berrangé
On Wed, Mar 16, 2022 at 06:40:08PM +0800, Peter Xu wrote: > On Wed, Mar 16, 2022 at 09:59:28AM +, Daniel P. Berrangé wrote: > > On Wed, Mar 16, 2022 at 11:30:59AM +0800, Peter Xu wrote: > > > On Tue, Mar 15, 2022 at 11:15:41AM +, Daniel P. Berrangé wrote: > > > > > I still remember you ment

Re: Time to introduce a migration protocol negotiation (Re: [PATCH v2 00/25] migration: Postcopy Preemption)

2022-03-16 Thread Peter Xu
On Wed, Mar 16, 2022 at 09:59:28AM +, Daniel P. Berrangé wrote: > On Wed, Mar 16, 2022 at 11:30:59AM +0800, Peter Xu wrote: > > On Tue, Mar 15, 2022 at 11:15:41AM +, Daniel P. Berrangé wrote: > > > > I still remember you mentioned the upper layer softwares can have > > > > assumption on usi

Re: Time to introduce a migration protocol negotiation (Re: [PATCH v2 00/25] migration: Postcopy Preemption)

2022-03-16 Thread Daniel P . Berrangé
On Wed, Mar 16, 2022 at 11:30:59AM +0800, Peter Xu wrote: > On Tue, Mar 15, 2022 at 11:15:41AM +, Daniel P. Berrangé wrote: > > > I still remember you mentioned the upper layer softwares can have > > > assumption on using only 1 pair of socket for migration, I think that > > > makes > > > post

Re: Time to introduce a migration protocol negotiation (Re: [PATCH v2 00/25] migration: Postcopy Preemption)

2022-03-15 Thread Peter Xu
On Tue, Mar 15, 2022 at 11:15:41AM +, Daniel P. Berrangé wrote: > > I still remember you mentioned the upper layer softwares can have > > assumption on using only 1 pair of socket for migration, I think that makes > > postcopy-preempt by default impossible. > > > > Why multifd is different her

Re: Time to introduce a migration protocol negotiation (Re: [PATCH v2 00/25] migration: Postcopy Preemption)

2022-03-15 Thread Daniel P . Berrangé
On Tue, Mar 15, 2022 at 02:13:43PM +0800, Peter Xu wrote: > On Mon, Mar 14, 2022 at 06:49:25PM +, Daniel P. Berrangé wrote: > > Taking a step back here and looking at the bigger picture of > > migration protocol configuration > > > > Almost every time we add a new feature to migration, we

Re: Time to introduce a migration protocol negotiation (Re: [PATCH v2 00/25] migration: Postcopy Preemption)

2022-03-15 Thread Daniel P . Berrangé
On Tue, Mar 15, 2022 at 10:43:45AM +, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > Almost every time we add a new feature to migration, we end up > > having to define at least one new migration parameter, then wire > > it up in libvirt, and then the mgmt

Re: Time to introduce a migration protocol negotiation (Re: [PATCH v2 00/25] migration: Postcopy Preemption)

2022-03-15 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Tue, Mar 01, 2022 at 04:51:09PM +, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > On Tue, Mar 01, 2022 at 10:27:10AM +, Daniel P. Berrangé wrote: > > > > > I also didn't know whether there's other limitati

Re: Time to introduce a migration protocol negotiation (Re: [PATCH v2 00/25] migration: Postcopy Preemption)

2022-03-14 Thread Peter Xu
On Mon, Mar 14, 2022 at 06:49:25PM +, Daniel P. Berrangé wrote: > Taking a step back here and looking at the bigger picture of > migration protocol configuration > > Almost every time we add a new feature to migration, we end up > having to define at least one new migration parameter, then

Time to introduce a migration protocol negotiation (Re: [PATCH v2 00/25] migration: Postcopy Preemption)

2022-03-14 Thread Daniel P . Berrangé
On Tue, Mar 01, 2022 at 04:51:09PM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Tue, Mar 01, 2022 at 10:27:10AM +, Daniel P. Berrangé wrote: > > > > I also didn't know whether there's other limitations of it. For > > > > example, > > > > will a new socke

Re: [PATCH v2 00/25] migration: Postcopy Preemption

2022-03-02 Thread Peter Xu
On Wed, Mar 02, 2022 at 12:14:30PM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > This is v2 of postcopy preempt series. It can also be found here: > > > > https://github.com/xzpeter/qemu/tree/postcopy-preempt > > > > RFC: > > https://lore.kernel.org/qemu-dev

Re: [PATCH v2 00/25] migration: Postcopy Preemption

2022-03-02 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > This is v2 of postcopy preempt series. It can also be found here: > > https://github.com/xzpeter/qemu/tree/postcopy-preempt > > RFC: > https://lore.kernel.org/qemu-devel/20220119080929.39485-1-pet...@redhat.com > V1: > https://lore.kernel.org/qemu-dev

Re: [PATCH v2 00/25] migration: Postcopy Preemption

2022-03-01 Thread Peter Xu
On Tue, Mar 01, 2022 at 06:05:50PM +, Daniel P. Berrangé wrote: > On Tue, Mar 01, 2022 at 06:55:00PM +0800, Peter Xu wrote: > > On Tue, Mar 01, 2022 at 10:27:10AM +, Daniel P. Berrangé wrote: > > So what I'm curious is why TLS is getting quite some attentions in the past > > few years but I

Re: [PATCH v2 00/25] migration: Postcopy Preemption

2022-03-01 Thread Peter Xu
On Tue, Mar 01, 2022 at 04:51:09PM +, Dr. David Alan Gilbert wrote: > Hmm, I think it's worth getting TLS working before putting the full > series in, because it might impact the way you wire the channels up - > it's going to take some care; but lets see which parts we can/should > take. IMHO

Re: [PATCH v2 00/25] migration: Postcopy Preemption

2022-03-01 Thread Daniel P . Berrangé
On Tue, Mar 01, 2022 at 06:55:00PM +0800, Peter Xu wrote: > On Tue, Mar 01, 2022 at 10:27:10AM +, Daniel P. Berrangé wrote: > So what I'm curious is why TLS is getting quite some attentions in the past > few years but I didn't even see any selftests included in migration-test on > tls. That's

Re: [PATCH v2 00/25] migration: Postcopy Preemption

2022-03-01 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Tue, Mar 01, 2022 at 10:27:10AM +, Daniel P. Berrangé wrote: > > > I also didn't know whether there's other limitations of it. For example, > > > will a new socket pair be a problem for any VM environment (either a > > > limitation from the management

Re: [PATCH v2 00/25] migration: Postcopy Preemption

2022-03-01 Thread Peter Xu
On Tue, Mar 01, 2022 at 10:27:10AM +, Daniel P. Berrangé wrote: > > I also didn't know whether there's other limitations of it. For example, > > will a new socket pair be a problem for any VM environment (either a > > limitation from the management app, container, and so on)? I think it's > >

Re: [PATCH v2 00/25] migration: Postcopy Preemption

2022-03-01 Thread Peter Xu
On Tue, Mar 01, 2022 at 09:25:55AM +, Daniel P. Berrangé wrote: > On Tue, Mar 01, 2022 at 04:39:00PM +0800, Peter Xu wrote: > > This is v2 of postcopy preempt series. It can also be found here: > > > > https://github.com/xzpeter/qemu/tree/postcopy-preempt > > > > RFC: > > https://lore.ker

Re: [PATCH v2 00/25] migration: Postcopy Preemption

2022-03-01 Thread Daniel P . Berrangé
On Tue, Mar 01, 2022 at 06:17:49PM +0800, Peter Xu wrote: > On Tue, Mar 01, 2022 at 09:25:55AM +, Daniel P. Berrangé wrote: > > On Tue, Mar 01, 2022 at 04:39:00PM +0800, Peter Xu wrote: > > > This is v2 of postcopy preempt series. It can also be found here: > > > > > > https://github.com/xz

Re: [PATCH v2 00/25] migration: Postcopy Preemption

2022-03-01 Thread Daniel P . Berrangé
On Tue, Mar 01, 2022 at 04:39:00PM +0800, Peter Xu wrote: > This is v2 of postcopy preempt series. It can also be found here: > > https://github.com/xzpeter/qemu/tree/postcopy-preempt > > RFC: > https://lore.kernel.org/qemu-devel/20220119080929.39485-1-pet...@redhat.com > V1: > https://lore

[PATCH v2 00/25] migration: Postcopy Preemption

2022-03-01 Thread Peter Xu
This is v2 of postcopy preempt series. It can also be found here: https://github.com/xzpeter/qemu/tree/postcopy-preempt RFC: https://lore.kernel.org/qemu-devel/20220119080929.39485-1-pet...@redhat.com V1: https://lore.kernel.org/qemu-devel/20220216062809.57179-1-pet...@redhat.com v1->v2 chan