Re: [PATCH v2 01/11] dirtylimit: Fix overflow when computing MB

2022-12-03 Thread Markus Armbruster
huang...@chinatelecom.cn writes: > From: Hyman Huang(黄勇) > > overity points out a overflow problem when computing MB, Coverity > dirty_ring_size and TARGET_PAGE_SIZE are both 32 bits, > multiplication will be done as a 32-bit operation, which > could overflow. Simplify the formula. > >

Re: [PATCH v2 01/11] dirtylimit: Fix overflow when computing MB

2022-11-29 Thread Peter Xu
On Mon, Nov 21, 2022 at 11:26:33AM -0500, huang...@chinatelecom.cn wrote: > From: Hyman Huang(黄勇) > > overity points out a overflow problem when computing MB, > dirty_ring_size and TARGET_PAGE_SIZE are both 32 bits, > multiplication will be done as a 32-bit operation, which > could

[PATCH v2 01/11] dirtylimit: Fix overflow when computing MB

2022-11-21 Thread huangy81
From: Hyman Huang(黄勇) overity points out a overflow problem when computing MB, dirty_ring_size and TARGET_PAGE_SIZE are both 32 bits, multiplication will be done as a 32-bit operation, which could overflow. Simplify the formula. Meanwhile, fix spelling mistake of variable name. Reported-by: