Re: [PATCH v2 01/11] hw/arm/aspeed: Do not directly map ram container onto main address bus

2021-04-21 Thread Philippe Mathieu-Daudé
On 4/21/21 7:53 AM, Cédric Le Goater wrote: > On 4/20/21 8:28 PM, Peter Xu wrote: >> On Sat, Apr 17, 2021 at 12:30:18PM +0200, Philippe Mathieu-Daudé wrote: >>> The RAM container is exposed as an AddressSpace. >> >> I didn't see where did ram_container got exposed as an address space. I guess I us

Re: [PATCH v2 01/11] hw/arm/aspeed: Do not directly map ram container onto main address bus

2021-04-20 Thread Cédric Le Goater
On 4/20/21 8:28 PM, Peter Xu wrote: > On Sat, Apr 17, 2021 at 12:30:18PM +0200, Philippe Mathieu-Daudé wrote: >> The RAM container is exposed as an AddressSpace. > > I didn't see where did ram_container got exposed as an address space. > > I see it's added as one subregion of get_system_memory(),

Re: [PATCH v2 01/11] hw/arm/aspeed: Do not directly map ram container onto main address bus

2021-04-20 Thread Peter Xu
On Sat, Apr 17, 2021 at 12:30:18PM +0200, Philippe Mathieu-Daudé wrote: > The RAM container is exposed as an AddressSpace. I didn't see where did ram_container got exposed as an address space. I see it's added as one subregion of get_system_memory(), which looks okay? -- Peter Xu

[PATCH v2 01/11] hw/arm/aspeed: Do not directly map ram container onto main address bus

2021-04-17 Thread Philippe Mathieu-Daudé
The RAM container is exposed as an AddressSpace. AddressSpaces root MemoryRegion must not be mapped into other MemoryRegion, therefore map the RAM container using an alias. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/aspeed.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff