Re: [PATCH v2 01/11] hw: encode accessing CPU index in MemTxAttrs

2022-09-26 Thread Alexander Graf
On 26.09.22 15:38, Alex Bennée wrote: We currently have hacks across the hw/ to reference current_cpu to work out what the current accessing CPU is. This breaks in some cases including using gdbstub to access HW state. As we have MemTxAttrs to describe details about the access lets extend it

Re: [PATCH v2 01/11] hw: encode accessing CPU index in MemTxAttrs

2022-09-26 Thread Peter Maydell
On Mon, 26 Sept 2022 at 16:24, Alex Bennée wrote: > > > Peter Maydell writes: > > I still don't see anything in this patchset that updates > > the code which currently assumes requester_id to be a PCI > > index to check that it hasn't been handed a MemTxAttrs > > that uses requester_id as a CPU

Re: [PATCH v2 01/11] hw: encode accessing CPU index in MemTxAttrs

2022-09-26 Thread Alex Bennée
Peter Maydell writes: > On Mon, 26 Sept 2022 at 15:13, Alex Bennée wrote: >> >> We currently have hacks across the hw/ to reference current_cpu to >> work out what the current accessing CPU is. This breaks in some cases >> including using gdbstub to access HW state. As we have MemTxAttrs to

Re: [PATCH v2 01/11] hw: encode accessing CPU index in MemTxAttrs

2022-09-26 Thread Peter Maydell
On Mon, 26 Sept 2022 at 15:13, Alex Bennée wrote: > > We currently have hacks across the hw/ to reference current_cpu to > work out what the current accessing CPU is. This breaks in some cases > including using gdbstub to access HW state. As we have MemTxAttrs to > describe details about the

[PATCH v2 01/11] hw: encode accessing CPU index in MemTxAttrs

2022-09-26 Thread Alex Bennée
We currently have hacks across the hw/ to reference current_cpu to work out what the current accessing CPU is. This breaks in some cases including using gdbstub to access HW state. As we have MemTxAttrs to describe details about the access lets extend it to mention if this is a CPU access and