Re: [PATCH v2 01/21] accel/tcg: Assert noreturn from write-only page for atomics

2024-10-08 Thread Peter Maydell
On Sat, 5 Oct 2024 at 21:06, Richard Henderson wrote: > > There should be no "just in case"; the page is already > in the tlb, and known to be not readable. > > Signed-off-by: Richard Henderson > --- > accel/tcg/cputlb.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git

Re: [PATCH v2 01/21] accel/tcg: Assert noreturn from write-only page for atomics

2024-10-07 Thread Helge Deller
On 10/5/24 22:05, Richard Henderson wrote: There should be no "just in case"; the page is already in the tlb, and known to be not readable. Signed-off-by: Richard Henderson Reviewed-by: Helge Deller --- accel/tcg/cputlb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff

[PATCH v2 01/21] accel/tcg: Assert noreturn from write-only page for atomics

2024-10-05 Thread Richard Henderson
There should be no "just in case"; the page is already in the tlb, and known to be not readable. Signed-off-by: Richard Henderson --- accel/tcg/cputlb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c index 117b516739..fd6459b695 1