Re: [PATCH v2 01/33] xics: Minor fixes for XICSFabric interface

2019-09-27 Thread Greg Kurz
On Fri, 27 Sep 2019 15:49:56 +1000 David Gibson wrote: > Interface instances should never be directly dereferenced. So, the common > practice is to make them incomplete types to make sure no-one does that. > XICSFrabric, however, had a dummy type which is less safe. > > We were also using OBJEC

[PATCH v2 01/33] xics: Minor fixes for XICSFabric interface

2019-09-26 Thread David Gibson
Interface instances should never be directly dereferenced. So, the common practice is to make them incomplete types to make sure no-one does that. XICSFrabric, however, had a dummy type which is less safe. We were also using OBJECT_CHECK() where we should have been using INTERFACE_CHECK(). Signe