Re: [PATCH v2 01/42] i386: pcmpestr 64-bit sign extension bug

2022-04-27 Thread Paolo Bonzini
On 4/25/22 00:01, Paul Brook wrote: The abs1 function in ops_sse.h only works sorrectly when the result fits in a signed int. This is fine most of the time because we're only dealing with byte sized values. However pcmp_elen helper function uses abs1 to calculate the absolute value of a cpu regi

Re: [PATCH v2 01/42] i386: pcmpestr 64-bit sign extension bug

2022-04-25 Thread Richard Henderson
On 4/24/22 15:01, Paul Brook wrote: The abs1 function in ops_sse.h only works sorrectly when the result fits in a signed int. This is fine most of the time because we're only dealing with byte sized values. However pcmp_elen helper function uses abs1 to calculate the absolute value of a cpu regi

[PATCH v2 01/42] i386: pcmpestr 64-bit sign extension bug

2022-04-24 Thread Paul Brook
The abs1 function in ops_sse.h only works sorrectly when the result fits in a signed int. This is fine most of the time because we're only dealing with byte sized values. However pcmp_elen helper function uses abs1 to calculate the absolute value of a cpu register. This incorrectly truncates to 32