Re: [PATCH v2 02/14] qapi: fix example of BLOCK_IMAGE_CORRUPTED event

Hi, On Mon, Mar 28, 2022 at 01:19:42PM +0200, Markus Armbruster wrote: > Victor Toso writes: > > > Hi, > > > > On Mon, Mar 28, 2022 at 10:54:41AM +0200, Markus Armbruster wrote: > >> Victor Toso writes: > >> > >> > Fatal is not optional. > >> > >> Recognizing that "Fatal" refers to member "fa

Re: [PATCH v2 02/14] qapi: fix example of BLOCK_IMAGE_CORRUPTED event

Victor Toso writes: > Hi, > > On Mon, Mar 28, 2022 at 10:54:41AM +0200, Markus Armbruster wrote: >> Victor Toso writes: >> >> > Fatal is not optional. >> >> Recognizing that "Fatal" refers to member "fatal" takes mental >> effort. Always use identifiers verbatim, including case. >> Where that

Re: [PATCH v2 02/14] qapi: fix example of BLOCK_IMAGE_CORRUPTED event

Hi, On Mon, Mar 28, 2022 at 10:54:41AM +0200, Markus Armbruster wrote: > Victor Toso writes: > > > Fatal is not optional. > > Recognizing that "Fatal" refers to member "fatal" takes mental > effort. Always use identifiers verbatim, including case. > Where that makes for confusing prose, prefix

Re: [PATCH v2 02/14] qapi: fix example of BLOCK_IMAGE_CORRUPTED event

Victor Toso writes: > Fatal is not optional. Recognizing that "Fatal" refers to member "fatal" takes mental effort. Always use identifiers verbatim, including case. Where that makes for confusing prose, prefix with a @ like @fatal, or rephrase, like "The member fatal". > > Signed-off-by: Victo

[PATCH v2 02/14] qapi: fix example of BLOCK_IMAGE_CORRUPTED event

Fatal is not optional. Signed-off-by: Victor Toso --- qapi/block-core.json | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index e89f2dfb5b..63c30a5378 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -5006,10