Re: [PATCH v2 02/23] target/i386: Return bool from disas_insn

2022-09-21 Thread Philippe Mathieu-Daudé via
On 8/9/22 14:14, Richard Henderson wrote: On 9/6/22 15:42, Philippe Mathieu-Daudé wrote: On 6/9/22 12:09, Richard Henderson wrote: Instead of returning the new pc, which is present in DisasContext, return true if an insn was translated. This is false when we detect a page crossing and must

Re: [PATCH v2 02/23] target/i386: Return bool from disas_insn

2022-09-08 Thread Richard Henderson
On 9/6/22 15:42, Philippe Mathieu-Daudé wrote: On 6/9/22 12:09, Richard Henderson wrote: Instead of returning the new pc, which is present in DisasContext, return true if an insn was translated. This is false when we detect a page crossing and must undo the insn under translation.

Re: [PATCH v2 02/23] target/i386: Return bool from disas_insn

2022-09-06 Thread Philippe Mathieu-Daudé via
On 6/9/22 12:09, Richard Henderson wrote: Instead of returning the new pc, which is present in DisasContext, return true if an insn was translated. This is false when we detect a page crossing and must undo the insn under translation. Signed-off-by: Richard Henderson ---

[PATCH v2 02/23] target/i386: Return bool from disas_insn

2022-09-06 Thread Richard Henderson
Instead of returning the new pc, which is present in DisasContext, return true if an insn was translated. This is false when we detect a page crossing and must undo the insn under translation. Signed-off-by: Richard Henderson --- target/i386/tcg/translate.c | 42