Re: [PATCH v2 02/33] block: Rename BdrvChildRole to BdrvChildClass

2020-02-11 Thread Alberto Garcia
On Tue 04 Feb 2020 06:08:17 PM CET, Max Reitz wrote: > This structure nearly only contains parent callbacks for child state > changes. It cannot really reflect a child's role, because different > roles may overlap (as we will see when real roles are introduced), and > because parents can have cust

Re: [PATCH v2 02/33] block: Rename BdrvChildRole to BdrvChildClass

2020-02-05 Thread Eric Blake
On 2/4/20 11:08 AM, Max Reitz wrote: This structure nearly only contains parent callbacks for child state changes. It cannot really reflect a child's role, because different roles may overlap (as we will see when real roles are introduced), and because parents can have custom callbacks even when

[PATCH v2 02/33] block: Rename BdrvChildRole to BdrvChildClass

2020-02-04 Thread Max Reitz
This structure nearly only contains parent callbacks for child state changes. It cannot really reflect a child's role, because different roles may overlap (as we will see when real roles are introduced), and because parents can have custom callbacks even when the child fulfills a standard role. S