Re: [PATCH v2 03/21] preallocate: Don't poll during permission updates

2023-10-09 Thread Denis V. Lunev
On 10/6/23 20:10, Vladimir Sementsov-Ogievskiy wrote: On 06.10.23 11:56, Kevin Wolf wrote: Am 05.10.2023 um 21:55 hat Vladimir Sementsov-Ogievskiy geschrieben: On 11.09.23 12:46, Kevin Wolf wrote: When the permission related BlockDriver callbacks are called, we are in the middle of an operatio

Re: [PATCH v2 03/21] preallocate: Don't poll during permission updates

2023-10-06 Thread Vladimir Sementsov-Ogievskiy
On 06.10.23 11:56, Kevin Wolf wrote: Am 05.10.2023 um 21:55 hat Vladimir Sementsov-Ogievskiy geschrieben: On 11.09.23 12:46, Kevin Wolf wrote: When the permission related BlockDriver callbacks are called, we are in the middle of an operation traversing the block graph. Polling in such a place i

Re: [PATCH v2 03/21] preallocate: Don't poll during permission updates

2023-10-06 Thread Kevin Wolf
Am 05.10.2023 um 21:55 hat Vladimir Sementsov-Ogievskiy geschrieben: > On 11.09.23 12:46, Kevin Wolf wrote: > > When the permission related BlockDriver callbacks are called, we are in > > the middle of an operation traversing the block graph. Polling in such a > > place is a very bad idea because t

Re: [PATCH v2 03/21] preallocate: Don't poll during permission updates

2023-10-05 Thread Vladimir Sementsov-Ogievskiy
On 11.09.23 12:46, Kevin Wolf wrote: When the permission related BlockDriver callbacks are called, we are in the middle of an operation traversing the block graph. Polling in such a place is a very bad idea because the graph could change in unexpected ways. In the future, callers will also hold t

[PATCH v2 03/21] preallocate: Don't poll during permission updates

2023-09-11 Thread Kevin Wolf
When the permission related BlockDriver callbacks are called, we are in the middle of an operation traversing the block graph. Polling in such a place is a very bad idea because the graph could change in unexpected ways. In the future, callers will also hold the graph lock, which is likely to turn