Re: [PATCH v2 06/11] tpm_crb: move ACPI table building to device interface

2023-08-07 Thread Igor Mammedov
On Tue, 1 Aug 2023 15:38:32 -0400 Stefan Berger wrote: > On 7/31/23 23:02, Joelle van Dyne wrote: > > On Mon, Jul 17, 2023 at 6:42 AM Igor Mammedov wrote: > >> > >> On Fri, 14 Jul 2023 13:21:33 -0400 > >> Stefan Berger wrote: > >> > >>> On 7/14/23 03:09, Joelle van Dyne wrote: > This

Re: [PATCH v2 06/11] tpm_crb: move ACPI table building to device interface

2023-08-01 Thread Stefan Berger
On 7/31/23 23:02, Joelle van Dyne wrote: On Mon, Jul 17, 2023 at 6:42 AM Igor Mammedov wrote: On Fri, 14 Jul 2023 13:21:33 -0400 Stefan Berger wrote: On 7/14/23 03:09, Joelle van Dyne wrote: This logic is similar to TPM TIS ISA device. Since TPM CRB can only support TPM 2.0 backends, we

Re: [PATCH v2 06/11] tpm_crb: move ACPI table building to device interface

2023-07-31 Thread Joelle van Dyne
On Mon, Jul 17, 2023 at 6:42 AM Igor Mammedov wrote: > > On Fri, 14 Jul 2023 13:21:33 -0400 > Stefan Berger wrote: > > > On 7/14/23 03:09, Joelle van Dyne wrote: > > > This logic is similar to TPM TIS ISA device. Since TPM CRB can only > > > support TPM 2.0 backends, we check for this in realize.

Re: [PATCH v2 06/11] tpm_crb: move ACPI table building to device interface

2023-07-17 Thread Igor Mammedov
On Fri, 14 Jul 2023 13:21:33 -0400 Stefan Berger wrote: > On 7/14/23 03:09, Joelle van Dyne wrote: > > This logic is similar to TPM TIS ISA device. Since TPM CRB can only > > support TPM 2.0 backends, we check for this in realize. > > > > Signed-off-by: Joelle van Dyne > > This patch changes

Re: [PATCH v2 06/11] tpm_crb: move ACPI table building to device interface

2023-07-14 Thread Stefan Berger
On 7/14/23 03:09, Joelle van Dyne wrote: This logic is similar to TPM TIS ISA device. Since TPM CRB can only support TPM 2.0 backends, we check for this in realize. Signed-off-by: Joelle van Dyne This patch changes the order of in which the ACPI table elements are created but doesn't matt

[PATCH v2 06/11] tpm_crb: move ACPI table building to device interface

2023-07-14 Thread Joelle van Dyne
This logic is similar to TPM TIS ISA device. Since TPM CRB can only support TPM 2.0 backends, we check for this in realize. Signed-off-by: Joelle van Dyne --- hw/i386/acpi-build.c | 23 --- hw/tpm/tpm_crb.c | 29 + 2 files changed, 29 insertion